DGNum/rpcd
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugin: use RTLD_LOCAL instead of RTLD_GLOBAL when loading library

Browse source 
RTLD_GLOBAL was used to allow plugins use each other symbols but this
facility was (most likely) never used and is a bad design anyway. If
there is a common code it should just go to a library.

Using RTLD_LOCAL on the other hand saves us from conflicting symbols
used by different plugins. An example can be iwinfo plugin using libnl.
If there appears to be another plugin using incompatible netlink
implementation this will result in a problem. Both plugins will start
using the same libnl which will break one of them.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Jo-Philipp Wich <jo@mein.io>
This commit is contained in:
Rafał Miłecki 2017-11-09 15:08:16 +01:00
parent 0577cfc1ac
commit 9a8640183c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugin.c
View file

@ -412,7 +412,7 @@ rpc_plugin_register_library(struct ubus_context *ctx, const char *path)
struct rpc_plugin *p; struct rpc_plugin *p;
void *dlh; void *dlh;
dlh = dlopen(path, RTLD_LAZY | RTLD_GLOBAL); dlh = dlopen(path, RTLD_LAZY | RTLD_LOCAL);
if (!dlh) if (!dlh)
return UBUS_STATUS_UNKNOWN_ERROR; return UBUS_STATUS_UNKNOWN_ERROR;