DGNum/rpcd
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

uci: fix memory leak in rpc_uci_replace_savedir()

Browse source 
The rpc_uci_replace_savedir() function did not take into account that libuci
uci_set_savedir() does an additional implicit uci_strdup() of the directory
path string when appending a new delta directory item.

Due to this oversight, only the struct uci_element items got freed, but not
the duplicated path string, leading to leaking memory when invoking the uci
api with session id argument.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This commit is contained in:
Jo-Philipp Wich 2018-05-13 21:13:05 +02:00
parent 10f787881d
commit 820621952d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
uci.c
View file

@ -212,8 +212,12 @@ rpc_uci_replace_savedir(const char *path)
{
struct uci_element *e, *tmp;
uci_foreach_element_safe(&cursor->delta_path, tmp, e)
uci_foreach_element_safe(&cursor->delta_path, tmp, e) {
if (e->name)
free(e->name);
free(e);
}
cursor->delta_path.prev = &cursor->delta_path;
cursor->delta_path.next = &cursor->delta_path;