DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

add datacenter location awareness with pseudo-driver (cmd and file) #4

Merged
Solvik merged 10 commits from feature/datacenter into master 2019-08-04 20:09:29 +02:00
Conversation 0 Commits 10 Files changed 8 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit f2195cf9e6 - Show all commits

4
netbox_agent/datacenter.py
View file

@ -40,5 +40,7 @@ class Datacenter():
def get(self): def get(self):
if not hasattr(self.driver, 'get'): if not hasattr(self.driver, 'get'):
raise Exception("Your driver {} doesn't have a get() function, please fix it".format(self.driver)) raise Exception(
"Your driver {} doesn't have a get() function, please fix it".format(self.driver)
)
return getattr(self.driver, 'get')(self.driver_value, DATACENTER_LOCATION_REGEX) return getattr(self.driver, 'get')(self.driver_value, DATACENTER_LOCATION_REGEX)
blotus commented 2019-08-04 19:00:16 +02:00 (Migrated from github.com)
Review
Copy link

We should properly check if the module has a get method to output a proper error message if a custom driver is not compliant instead of an ugly stacktrace.

We should properly check if the module has a `get` method to output a proper error message if a custom driver is not compliant instead of an ugly stacktrace.
Solvik commented 2019-08-04 19:19:14 +02:00 (Migrated from github.com)
Review
Copy link

Fixed in last commit

Fixed in last commit