DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

fix ethtool class in case ethtool works but returns nothing #123

Merged
Solvik merged 1 commit from fix_ethtool into master 2020-04-19 12:19:29 +02:00
Conversation 0 Commits 1 Files changed 1 +5 -5
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
netbox_agent/ethtool.py
View file

@ -65,11 +65,11 @@ class Ethtool():
def _parse_ethtool_module_output(self): def _parse_ethtool_module_output(self):
status, output = subprocess.getstatusoutput('ethtool -m {}'.format(self.interface)) status, output = subprocess.getstatusoutput('ethtool -m {}'.format(self.interface))
if status != 0: if status == 0:
return {} r = re.search(r'Identifier.*\((\w+)\)', output)
r = re.search(r'Identifier.*\((\w+)\)', output) if r and len(r.groups()) > 0:
if r and len(r.groups()) > 0: return {'form_factor': r.groups()[0]}
return {'form_factor': r.groups()[0]} return {}
def parse(self): def parse(self):
if which('ethtool') is None: if which('ethtool') is None: