fix: lshw crashes due to duplicate logical name #227 #271
No reviewers
Labels
No labels
help wanted
need testing
status: accepted
status: discussing
type: bug
type: documentation
type: duplicate
type: enhancement
type:hardware
type: invalid
type: major feature
type: minor feature
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: DGNum/netbox-agent#271
Loading…
Reference in a new issue
No description provided.
Delete branch "fix-227-lshw"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #227
Newer versions of LSHW can return multiple logical names. This is parsed as an array. Netbox-agent assumes that the name is always a string, hence the failure.
This patch checks if the logical name output is a string or an array. If it is an array each logical name is added to the unknown interfaces list.
In which python version
list.push
method exist ? it is notlist.append
?