DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

Added platform to the config with auto-detect as fallback #216

Merged
cyrinux merged 7 commits from feature/platform into master 2022-04-01 08:57:24 +02:00
Conversation 10 Commits 7 Files changed 4 +37 -2
cyrinux commented 2022-03-31 17:09:40 +02:00 (Migrated from github.com)
Copy link

https://github.com/Solvik/netbox-agent/pull/215 with auto detect device platform / os added

https://github.com/Solvik/netbox-agent/pull/215 with auto detect device platform / os added
cyrinux commented 2022-03-31 17:13:23 +02:00 (Migrated from github.com)
Copy link

superseed https://github.com/Solvik/netbox-agent/pull/215

superseed https://github.com/Solvik/netbox-agent/pull/215
KivraChristoffer commented 2022-03-31 19:26:56 +02:00 (Migrated from github.com)
Copy link

@cyrinux , works, but with no config, it would not autodetect, but it will not remove a value if its defined and there is no config.
So during my test all works but not the autodetect.

( tested on centos 8.2 )

@cyrinux , works, but with no config, it would not autodetect, but it will not remove a value if its defined and there is no config. So during my test all works but not the autodetect. ( tested on centos 8.2 )
cyrinux commented 2022-03-31 19:33:51 +02:00 (Migrated from github.com)
Copy link

Thanks for the test, will try on my side, what python version are you using ?

Thanks for the test, will try on my side, what python version are you using ?
KivraChristoffer commented 2022-03-31 19:39:40 +02:00 (Migrated from github.com)
Copy link

@cyrinux
python --version Python 3.6.8 (virtend-netbox

@cyrinux `python --version Python 3.6.8 (virtend-netbox`
cyrinux commented 2022-03-31 19:55:33 +02:00 (Migrated from github.com)
Copy link

@KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good.

@KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good.
KivraChristoffer commented 2022-03-31 20:00:21 +02:00 (Migrated from github.com)
Copy link

Would you like me to do the tests again ?

Den tors 31 mars 2022 19:55Cyril Levis @.***> skrev:

@KivraChristoffer https://github.com/KivraChristoffer I forgot to
remove a condition, it should be ok with this last fix, I test on my side
and its good.

—
Reply to this email directly, view it on GitHub
https://github.com/Solvik/netbox-agent/pull/216#issuecomment-1084927019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis ***@***.***> skrev: > @KivraChristoffer <https://github.com/KivraChristoffer> I forgot to > remove a condition, it should be ok with this last fix, I test on my side > and its good. > > — > Reply to this email directly, view it on GitHub > <https://github.com/Solvik/netbox-agent/pull/216#issuecomment-1084927019>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >
cyrinux commented 2022-03-31 20:07:49 +02:00 (Migrated from github.com)
Copy link

Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis @.> skrev:
…
@KivraChristoffer https://github.com/KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA . You are receiving this because you were mentioned.Message ID: @.>

Yes please ;-)

> Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis ***@***.***> skrev: > […](#) > @KivraChristoffer <https://github.com/KivraChristoffer> I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. — Reply to this email directly, view it on GitHub <[#216 (comment)](https://github.com/Solvik/netbox-agent/pull/216#issuecomment-1084927019)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA> . You are receiving this because you were mentioned.Message ID: ***@***.***> Yes please ;-)
KivraChristoffer commented 2022-04-01 08:46:58 +02:00 (Migrated from github.com)
Copy link

Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis @.> skrev:
…
@KivraChristoffer https://github.com/KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA . You are receiving this because you were mentioned.Message ID: _@**.**_>

Yes please ;-)

allt worked good,
automated found this:

CentOS Linux 8.2.2004 Core

CentOS Linux 8.2.2004 Core

> > Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis _**@**_._**> skrev: > > […](#) > > @KivraChristoffer https://github.com/KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. — Reply to this email directly, view it on GitHub <[#216 (comment)](https://github.com/Solvik/netbox-agent/pull/216#issuecomment-1084927019)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA . You are receiving this because you were mentioned.Message ID: _**@**_.**_> > > Yes please ;-) allt worked good, automated found this: CentOS Linux 8.2.2004 Core -- [CentOS Linux 8.2.2004 Core](https://netbox.kivra.net/dcim/platforms/23/)
🎉 1
cyrinux commented 2022-04-01 08:57:20 +02:00 (Migrated from github.com)
Copy link

Thanks, I will merge this and try to do a release soon.
Bug reports and new features appreciate 😺

Thanks, I will merge this and try to do a release soon. Bug reports and new features appreciate 😺
KivraChristoffer commented 2022-04-01 09:19:55 +02:00 (Migrated from github.com)
Copy link

Thanks, I will merge this and try to do a release soon. Bug reports and new features appreciate smiley_cat

We have 2 others comming.
1 where is a raidcard dont have any disks attached.
2 report in diskspace ( mainly vm's )

> Thanks, I will merge this and try to do a release soon. Bug reports and new features appreciate smiley_cat We have 2 others comming. 1 where is a raidcard dont have any disks attached. 2 report in diskspace ( mainly vm's )
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
help wanted

Extra attention is needed

  
need testing

   
status: accepted

   
status: discussing

   
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: duplicate

This issue or pull request already exists

  
type: enhancement

New feature or request

  
type:hardware

Mostly new hardware

  
type: invalid

This doesn't seem right

  
type: major feature

   
type: minor feature
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
help wanted
need testing
status: accepted
status: discussing
type: bug
type: documentation
type: duplicate
type: enhancement
type:hardware
type: invalid
type: major feature
type: minor feature
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/netbox-agent#216
No description provided.
Delete branch "feature/platform"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?