DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

Fix inventory crash on nvme binary too old or absent #170

Merged
cyrinux merged 2 commits from fix_nvme_crash into master 2020-10-14 12:40:20 +02:00
Conversation 0 Commits 2 Files changed 1 +20 -14
cyrinux commented 2020-09-30 14:25:24 +02:00 (Migrated from github.com)
Copy link

When nvme binary absent or too old and no json output, this crash the inventory, i prefer just pass nvme inventory and continue

When nvme binary absent or too old and no json output, this crash the inventory, i prefer just pass nvme inventory and continue
Solvik (Migrated from github.com) reviewed 2020-09-30 16:24:31 +02:00
netbox_agent/lshw.py
Solvik (Migrated from github.com) commented 2020-09-30 16:24:30 +02:00
Copy link

Can we log in warning that the binary nvme isn't available and we're missing a feature ?
If we don't do that, the user may never now

Can we log in warning that the binary nvme isn't available and we're missing a feature ? If we don't do that, the user may never now
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
help wanted

Extra attention is needed

  
need testing

   
status: accepted

   
status: discussing

   
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: duplicate

This issue or pull request already exists

  
type: enhancement

New feature or request

  
type:hardware

Mostly new hardware

  
type: invalid

This doesn't seem right

  
type: major feature

   
type: minor feature
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
help wanted
need testing
status: accepted
status: discussing
type: bug
type: documentation
type: duplicate
type: enhancement
type:hardware
type: invalid
type: major feature
type: minor feature
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/netbox-agent#170
No description provided.
Delete branch "fix_nvme_crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?