config.py does not support netbox url with self-signed certificates #147

New issue

Closed

opened 2020-07-04 18:59:32 +02:00 by strus38 · 5 comments

strus38 commented

2020-07-04 18:59:32 +02:00

(Migrated from github.com)

Hi
could you update config.py, so it can work with self-signed certificates?
Proposal:

add an option to netbox-agent: --ignore-ssl-verify

Modifications (in addition of adding the option):

in config.py line line 1

import requests
import urllib3
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

then line 80:

if (no_ssl_verify):
    session = requests.Session()
    session.verify = False

nb = pynetbox.api(
     url=get_config().netbox.url,
     token=get_config().netbox.token
)
if (no_ssl_verify):
    nb.http_session = session
return nb

Thanks!

Hi could you update config.py, so it can work with self-signed certificates? Proposal: - add an option to netbox-agent: --ignore-ssl-verify Modifications (in addition of adding the option): - in config.py line line 1 ``` import requests import urllib3 urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) ``` then line 80: ``` if (no_ssl_verify): session = requests.Session() session.verify = False nb = pynetbox.api( url=get_config().netbox.url, token=get_config().netbox.token ) if (no_ssl_verify): nb.http_session = session return nb ``` Thanks!

Solvik commented

2020-07-07 20:05:25 +02:00

(Migrated from github.com)

If you're able to propose a PR and test it, that would be very nice :)

strus38 commented

2020-07-08 09:40:07 +02:00

(Migrated from github.com)

The PR 152 is opened. Feel free to merge or comment it.
Thanks!

The PR 152 is opened. Feel free to merge or comment it. Thanks!

Solvik commented

2020-07-08 09:41:20 +02:00

(Migrated from github.com)