Some fixes that prevent crash on register new a server #128

Merged
cyrinux merged 1 commit from cyrinux/somes_fix into master 2020-06-08 14:16:51 +02:00
cyrinux commented 2020-06-06 15:21:12 +02:00 (Migrated from github.com)

Hi @Solvik,

I'm trying to continue the deployment of netbox-agent and updating it by the way where you know maybe :)

Will push some fix like this while I progress and try to bring feature if I got ideas :)

Regards,

Hi @Solvik, I'm trying to continue the deployment of netbox-agent and updating it by the way where you know maybe :) Will push some fix like this while I progress and try to bring feature if I got ideas :) Regards,
ramnes commented 2020-06-06 21:20:29 +02:00 (Migrated from github.com)

Can you please make a dedicated commit for style changes? Right now it's pretty hard to see what you're actually fixing, there's simply too much noise.

Can you please make a dedicated commit for style changes? Right now it's pretty hard to see what you're actually fixing, there's simply too much noise.
cyrinux commented 2020-06-07 09:00:47 +02:00 (Migrated from github.com)

Hi @ramnes , sure sorry, I forgot to disable my formatter on my last commit.
What do you think about using the python black formatter?

Hi @ramnes , sure sorry, I forgot to disable my formatter on my last commit. What do you think about using the python black formatter?
ramnes commented 2020-06-08 13:33:46 +02:00 (Migrated from github.com)

Feel free to open an issue about this! (Spoiler: I'd prefer not to, but then it's mostly about what @Solvik wants.)

Feel free to open an issue about this! (Spoiler: I'd prefer not to, but then it's mostly about what @Solvik wants.)
cyrinux commented 2020-06-08 13:36:58 +02:00 (Migrated from github.com)

No problem for black, not my priority for the moment, i just need to disable it ;)

No problem for black, not my priority for the moment, i just need to disable it ;)
ramnes (Migrated from github.com) approved these changes 2020-06-08 13:51:18 +02:00
ramnes (Migrated from github.com) left a comment

LGTM 👍

I think the whole custom_arg thing could be refactored so that we don't have to do this, but this is most likely good enough for now.

LGTM :+1: I think the whole `custom_arg` thing could be refactored so that we don't have to do this, but this is most likely good enough for now.
Sign in to join this conversation.
No description provided.