Some fixes that prevent crash on register new a server #128
No reviewers
Labels
No labels
help wanted
need testing
status: accepted
status: discussing
type: bug
type: documentation
type: duplicate
type: enhancement
type:hardware
type: invalid
type: major feature
type: minor feature
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: DGNum/netbox-agent#128
Loading…
Reference in a new issue
No description provided.
Delete branch "cyrinux/somes_fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi @Solvik,
I'm trying to continue the deployment of netbox-agent and updating it by the way where you know maybe :)
Will push some fix like this while I progress and try to bring feature if I got ideas :)
Regards,
Can you please make a dedicated commit for style changes? Right now it's pretty hard to see what you're actually fixing, there's simply too much noise.
Hi @ramnes , sure sorry, I forgot to disable my formatter on my last commit.
What do you think about using the python black formatter?
Feel free to open an issue about this! (Spoiler: I'd prefer not to, but then it's mostly about what @Solvik wants.)
No problem for black, not my priority for the moment, i just need to disable it ;)
LGTM 👍
I think the whole
custom_arg
thing could be refactored so that we don't have to do this, but this is most likely good enough for now.