Adds a generic vendor for unrecognizable systems #105

2020-01-21T00:05:19+01:00

ThomasADavis commented

2020-01-21 00:05:19 +01:00

(Migrated from github.com)

Adds a generic vendor for unrecognizable systems

ramnes (Migrated from github.com) approved these changes 2020-01-21 12:21:14 +01:00

ramnes (Migrated from github.com) left a comment

Minor suggestions but LGTM!

netbox_agent/cli.py

					
				@ -2,6 +2,7 @@ import netbox_agent.dmidecode as dmidecode

				from netbox_agent.config import config

				from netbox_agent.logging import logging  # NOQA

				from netbox_agent.vendors.dell import DellHost

ramnes (Migrated from github.com) commented

2020-01-21 12:19:50 +01:00

        server = GenericHost

```suggestion server = GenericHost ```

ramnes (Migrated from github.com) commented

2020-01-21 12:20:56 +01:00

I'd suggest removing this diff as we'll fall into the exception catching block anyway.

Sign in to join this conversation.

No reviewers

ramnes

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/netbox-agent#105