DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

error handling in case switch mgmt interface doesnt have IP

Browse source
This commit is contained in:
Solvik Blum 2019-08-23 15:15:36 +02:00
parent 767fb2c561
commit c9ddee73e8
No known key found for this signature in database
GPG key ID: CC12B3DC262B6C47
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
netbox_agent/network.py
View file

@ -348,13 +348,13 @@ class Network():
return nb_server_interface return nb_server_interface
def create_or_update_cable(self, switch_ip, switch_interface, nb_server_interface): def create_or_update_cable(self, switch_ip, switch_interface, nb_server_interface):
update = False
if nb_server_interface.cable is None: if nb_server_interface.cable is None:
update = True update = True
nb_server_interface = self.connect_interface_to_switch( nb_server_interface = self.connect_interface_to_switch(
switch_ip, switch_interface, nb_server_interface switch_ip, switch_interface, nb_server_interface
) )
else: else:
update = False
nb_sw_int = nb_server_interface.cable.termination_b nb_sw_int = nb_server_interface.cable.termination_b
nb_sw = nb_sw_int.device nb_sw = nb_sw_int.device
nb_mgmt_int = nb.dcim.interfaces.get( nb_mgmt_int = nb.dcim.interfaces.get(
@ -365,7 +365,12 @@ class Network():
interface_id=nb_mgmt_int.id interface_id=nb_mgmt_int.id
) )
if nb_mgmt_ip is None: if nb_mgmt_ip is None:
pass logging.error(
'Switch {switch_ip} does not have IP on its management interface'.format(
switch_ip=switch_ip,
)
)
return update, nb_server_interface
# Netbox IP is always IP/Netmask # Netbox IP is always IP/Netmask
nb_mgmt_ip = nb_mgmt_ip.address.split('/')[0] nb_mgmt_ip = nb_mgmt_ip.address.split('/')[0]