DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

Merge pull request #266 from Varriount/patch-2

Browse source 
Simplify `is_vm` function
This commit is contained in:
Cyril Levis 2023-02-27 14:37:10 +01:00 • committed by GitHub
commit 7259c7602d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
netbox_agent/virtualmachine.py
View file

@ -10,19 +10,26 @@ from netbox_agent.network import VirtualNetwork
def is_vm(dmi): def is_vm(dmi):
bios = dmidecode.get_by_type(dmi, 'BIOS') bios = dmidecode.get_by_type(dmi, 'BIOS')[0]
system = dmidecode.get_by_type(dmi, 'System') system = dmidecode.get_by_type(dmi, 'System')[0]
if 'Hyper-V' in bios[0]['Version'] or \ return (
'Xen' in bios[0]['Version'] or \ (
'Google Compute Engine' in system[0]['Product Name'] or \ 'Hyper-V' in bios['Version'] or
('Amazon EC2' in system[0]['Manufacturer'] and not system[0]['Product Name'].endswith('.metal')) or \ 'Xen' in bios['Version'] or
'RHEV Hypervisor' in system[0]['Product Name'] or \ 'Google Compute Engine' in system['Product Name']
'QEMU' in system[0]['Manufacturer'] or \ ) or
'VirtualBox' in bios[0]['Version'] or \ (
'VMware' in system[0]['Manufacturer']: (
return True 'Amazon EC2' in system['Manufacturer'] and
return False not system['Product Name'].endswith('.metal')
) or
'RHEV Hypervisor' in system['Product Name'] or
'QEMU' in system['Manufacturer'] or
'VirtualBox' in bios['Version'] or
'VMware' in system['Manufacturer']
)
)
class VirtualMachine(object): class VirtualMachine(object):