DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

pep8 fixes

Browse source
This commit is contained in:
Solvik Blum 2019-08-20 17:27:31 +02:00
parent c508fa17f0
commit 4afd3b9170
No known key found for this signature in database
GPG key ID: CC12B3DC262B6C47
4 changed files with 22 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

11
netbox_agent/raid/dell.py
View file

@ -3,6 +3,7 @@ import json
from netbox_agent.raid.base import Raid, RaidController
class StorcliController(RaidController):
def __init__(self, controller_index, data):
self.data = data
@ -22,14 +23,18 @@ class StorcliController(RaidController):
def get_physical_disks(self):
ret = []
output = subprocess.getoutput('storcli /c{}/eall/sall show all J'.format(self.controller_index))
output = subprocess.getoutput(
'storcli /c{}/eall/sall show all J'.format(self.controller_index)
)
drive_infos = json.loads(output)['Controllers'][self.controller_index]['Response Data']
for physical_drive in self.data['PD LIST']:
enclosure = physical_drive.get('EID:Slt').split(':')[0]
slot = physical_drive.get('EID:Slt').split(':')[1]
size = physical_drive.get('Size').strip()
drive_identifier = 'Drive /c{}/e{}/s{}'.format(str(self.controller_index), str(enclosure), str(slot))
drive_identifier = 'Drive /c{}/e{}/s{}'.format(
str(self.controller_index), str(enclosure), str(slot)
)
drive_attr = drive_infos['{} - Detailed Information'.format(drive_identifier)]\
['{} Device attributes'.format(drive_identifier)]
ret.append({
@ -46,7 +51,7 @@ class StorcliRaid(Raid):
self.controllers = []
if len([
x for x in self.data['Controllers'] \
x for x in self.data['Controllers']
if x['Command Status']['Status'] == 'Success'
]) > 0:
for controller in self.data['Controllers']: