DGNum/netbox-agent
6
0
Fork 0
Code Issues 28 Pull requests 9 Projects Releases 14 Packages Wiki Activity Actions

fix: hp raid, prevent us to miss some errors when matching only returncode 1

Browse source 
Signed-off-by: Cyril Levis <git@levis.name>
This commit is contained in:
Cyril Levis 2022-04-04 10:51:18 +02:00
parent 5f0aae6c01
commit 2f23844dfd
No known key found for this signature in database
GPG key ID: 6DB88737C11F5A48
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
netbox_agent/raid/hp.py
View file

@ -20,13 +20,13 @@ def ssacli(sub_command):
)
p.wait()
stdout = p.stdout.read().decode("utf-8")
if p.returncode == 1 and stdout.find('does not have any physical') == -1:
if p.returncode != 0 and 'does not have any physical' not in stdout:
mesg = "Failed to execute command '{}':\n{}".format(
" ".join(command), stdout
)
raise HPRaidControllerError(mesg)
else:
if stdout.find('does not have any physical') != -1:
if 'does not have any physical' in stdout:
return list()
else:
lines = stdout.split('\n')