43a103ff17
Fix out of bounds read in blobmsg_parse and blobmsg_check_name. The out of bounds read happens because blob_attr and blobmsg_hdr have flexible array members, whose size is 0 in the corresponding sizeofs. For example the __blob_for_each_attr macro checks whether rem >= sizeof(struct blob_attr). However, what LibFuzzer discovered was, if the input data was only 4 bytes, the data would be casted to blob_attr, and later on blob_data(attr) would be called even though attr->data was empty. The same issue could appear with data larger than 4 bytes, where data wasn't empty, but contained only the start of the blobmsg_hdr struct, and blobmsg_hdr name was empty. The bugs were discovered by fuzzing blobmsg_parse and blobmsg_array_parse with LibFuzzer. CC: Luka Perkov <luka.perkov@sartura.hr> Reviewed-by: Jo-Philipp Wich <jo@mein.io> Signed-off-by: Juraj Vijtiuk <juraj.vijtiuk@sartura.hr> [refactored some checks, added fuzz inputs, adjusted unit test results] Signed-off-by: Petr Štetiar <ynezz@true.cz> |
||
---|---|---|
.. | ||
cram | ||
fuzz | ||
shunit2 | ||
CMakeLists.txt | ||
test-avl.c | ||
test-b64.c | ||
test-b64_decode.c | ||
test-b64_encode.c | ||
test-blob-parse.c | ||
test-blobmsg-parse.c | ||
test-blobmsg-procd-instance.c | ||
test-blobmsg.c | ||
test-json-script.c | ||
test-list.c | ||
test-runqueue.c |