DGNum/libubox
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lua/uloop: fd_add: use absolute indices for arguments

Browse source 
Instead of having to adjust the index repeatedly as the stack is
manipulated, use absolute addressing for the function arguments, so they
stay the same throughout the call.  Zero functional change, just
subjectively easier to follow variables.

Signed-off-by: Karl Palsson <karlp@etactica.com>
This commit is contained in:
Karl Palsson 2020-06-30 10:38:43 +00:00 committed by Petr Štetiar
parent c0941d3289
commit 53b9a2123f
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lua/uloop.c
View file

@ -233,24 +233,23 @@ static int ul_ufd_add(lua_State *L)
int ref; int ref;
int fd_ref; int fd_ref;
flags = luaL_checkinteger(L, -1); flags = luaL_checkinteger(L, 3);
if (!flags) { if (!flags) {
lua_pushstring(L, "flags cannot be zero"); lua_pushstring(L, "flags cannot be zero");
lua_error(L); lua_error(L);
} }
lua_pop(L, 1);
luaL_checktype(L, -1, LUA_TFUNCTION); luaL_checktype(L, 2, LUA_TFUNCTION);
fd = get_sock_fd(L, -2); fd = get_sock_fd(L, 1);
lua_getglobal(L, "__uloop_cb"); lua_getglobal(L, "__uloop_cb");
lua_pushvalue(L, -2); lua_pushvalue(L, 2);
ref = luaL_ref(L, -2); ref = luaL_ref(L, -2);
lua_pop(L, 1); lua_pop(L, 1);
lua_getglobal(L, "__uloop_fds"); lua_getglobal(L, "__uloop_fds");
lua_pushvalue(L, -3); lua_pushvalue(L, 1);
fd_ref = luaL_ref(L, -2); fd_ref = luaL_ref(L, -2);
lua_pop(L, 1); lua_pop(L, 1);