DGNum/libubox
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

blobmsg: make blobmsg_len and blobmsg_data_len return unsigned value

Browse source 
One usually doesn't guard against negative length values in the code.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
This commit is contained in:
Petr Štetiar 2019-12-10 11:53:23 +01:00
parent 2df6d35e32
commit 4dfd24ed88
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
blobmsg.c
View file

@ -35,7 +35,8 @@ bool blobmsg_check_attr(const struct blob_attr *attr, bool name)
{ {
const struct blobmsg_hdr *hdr; const struct blobmsg_hdr *hdr;
const char *data; const char *data;
int id, len; size_t len;
int id;
if (blob_len(attr) < sizeof(struct blobmsg_hdr)) if (blob_len(attr) < sizeof(struct blobmsg_hdr))
return false; return false;

4
blobmsg.h
View file

@ -86,7 +86,7 @@ static inline void *blobmsg_data(const struct blob_attr *attr)
return data; return data;
} }
static inline int blobmsg_data_len(const struct blob_attr *attr) static inline size_t blobmsg_data_len(const struct blob_attr *attr)
{ {
uint8_t *start, *end; uint8_t *start, *end;
@ -99,7 +99,7 @@ static inline int blobmsg_data_len(const struct blob_attr *attr)
return blob_len(attr) - (end - start); return blob_len(attr) - (end - start);
} }
static inline int blobmsg_len(const struct blob_attr *attr) static inline size_t blobmsg_len(const struct blob_attr *attr)
{ {
return blobmsg_data_len(attr); return blobmsg_data_len(attr);
} }