DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

l2_packet_ndis: Fix overlapped write not to corrupt stack

Browse source 
When using overlapped write, we must have the provided memory
areas available during the operation and cannot just use stack
unless we wait for the completion within the function. In the case
of TX here, we can easily wait for the completion since it is likely
to happen immediately. In addition, this provides more reliable
success/failure return value for l2_packet_send(). [Bug 328]
This commit is contained in:
Jouni Malinen 2010-09-02 13:23:14 +03:00
parent de1267d4eb
commit f4e5fd948a
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/l2_packet/l2_packet_ndis.c
View file

@ -137,11 +137,17 @@ int l2_packet_send(struct l2_packet_data *l2, const u8 *dst_addr, u16 proto,
DWORD err = GetLastError(); DWORD err = GetLastError();
#ifndef _WIN32_WCE #ifndef _WIN32_WCE
if (err == ERROR_IO_PENDING) { if (err == ERROR_IO_PENDING) {
/* For now, just assume that the packet will be sent in wpa_printf(MSG_DEBUG, "L2(NDISUIO): Wait for pending "
* time before the next write happens. This could be "write to complete");
* cleaned up at some point to actually wait for res = GetOverlappedResult(
* completion before starting new writes. driver_ndis_get_ndisuio_handle(), &overlapped,
*/ &written, TRUE);
if (!res) {
wpa_printf(MSG_DEBUG, "L2(NDISUIO): "
"GetOverlappedResult failed: %d",
(int) GetLastError());
return -1;
}
return 0; return 0;
} }
#endif /* _WIN32_WCE */ #endif /* _WIN32_WCE */