DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

WPS: Remove unused error path code

Browse source
This commit is contained in:
Jouni Malinen 2010-10-17 20:10:09 +03:00
parent acd0ef4d3c
commit d0ebf3285f
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/wps/wps_upnp.c
View file

@ -307,7 +307,6 @@ static void subscr_addr_add_url(struct subscription *s, const char *url)
struct addrinfo *result = NULL; struct addrinfo *result = NULL;
struct addrinfo *rp; struct addrinfo *rp;
int rerr; int rerr;
struct subscr_addr *a = NULL;
/* url MUST begin with http: */ /* url MUST begin with http: */
if (os_strncasecmp(url, "http://", 7)) if (os_strncasecmp(url, "http://", 7))
@ -367,6 +366,8 @@ static void subscr_addr_add_url(struct subscription *s, const char *url)
goto fail; goto fail;
} }
for (rp = result; rp; rp = rp->ai_next) { for (rp = result; rp; rp = rp->ai_next) {
struct subscr_addr *a;
/* Limit no. of address to avoid denial of service attack */ /* Limit no. of address to avoid denial of service attack */
if (dl_list_len(&s->addr_list) >= MAX_ADDR_PER_SUBSCRIPTION) { if (dl_list_len(&s->addr_list) >= MAX_ADDR_PER_SUBSCRIPTION) {
wpa_printf(MSG_INFO, "WPS UPnP: subscr_addr_add_url: " wpa_printf(MSG_INFO, "WPS UPnP: subscr_addr_add_url: "
@ -390,14 +391,12 @@ static void subscr_addr_add_url(struct subscription *s, const char *url)
a->saddr.sin_port = htons(port); a->saddr.sin_port = htons(port);
dl_list_add(&s->addr_list, &a->list); dl_list_add(&s->addr_list, &a->list);
a = NULL; /* don't free it below */
} }
fail: fail:
if (result) if (result)
freeaddrinfo(result); freeaddrinfo(result);
os_free(scratch_mem); os_free(scratch_mem);
os_free(a);
} }