RADIUS: Use os_memcmp_const() for hash/password comparisons
This makes the implementation less likely to provide useful timing information to potential attackers from comparisons of information received from a remote device and private material known only by the authorized devices. Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
parent
ce9c9bcc38
commit
c2371953f8
2 changed files with 6 additions and 6 deletions
|
@ -864,7 +864,7 @@ radius_server_macacl(struct radius_server_data *data,
|
|||
os_free(tmp.password);
|
||||
|
||||
if (res < 0 || pw_len != (size_t) res ||
|
||||
os_memcmp(pw, buf, res) != 0) {
|
||||
os_memcmp_const(pw, buf, res) != 0) {
|
||||
RADIUS_DEBUG("Incorrect User-Password");
|
||||
code = RADIUS_CODE_ACCESS_REJECT;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue