DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fixed fwrite error path in eap_fast_write_pac not to free buf

Browse source 
Caller expects the buffer to be allocated on error, so eap_fast_write_pac()
must be consistent with its behavior on error paths.
This commit is contained in:
Jouni Malinen 2008-11-01 17:09:28 +02:00
parent 8caa12b46c
commit ac987fb7de
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/eap_peer/eap_fast_pac.c
View file

@ -533,8 +533,6 @@ static void eap_fast_write(char **buf, char **pos, size_t *buf_len,
static int eap_fast_write_pac(struct eap_sm *sm, const char *pac_file, static int eap_fast_write_pac(struct eap_sm *sm, const char *pac_file,
char *buf, size_t len) char *buf, size_t len)
{ {
int ret = 0;
if (os_strncmp(pac_file, "blob://", 7) == 0) { if (os_strncmp(pac_file, "blob://", 7) == 0) {
struct wpa_config_blob *blob; struct wpa_config_blob *blob;
blob = os_zalloc(sizeof(*blob)); blob = os_zalloc(sizeof(*blob));
@ -560,13 +558,14 @@ static int eap_fast_write_pac(struct eap_sm *sm, const char *pac_file,
if (fwrite(buf, 1, len, f) != len) { if (fwrite(buf, 1, len, f) != len) {
wpa_printf(MSG_INFO, "EAP-FAST: Failed to write all " wpa_printf(MSG_INFO, "EAP-FAST: Failed to write all "
"PACs into '%s'", pac_file); "PACs into '%s'", pac_file);
ret = -1; fclose(f);
return -1;
} }
os_free(buf); os_free(buf);
fclose(f); fclose(f);
} }
return ret; return 0;
} }