DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Enable the close-on-exec flag for the debug log file descriptor

Browse source 
On Linux this flag will make sure that no file descriptor is
accidentally leaked into potential child processes. While this is not a
problem right now, it is considered to be good practice these days when
dealing with file descriptors on Linux.

Signed-off-by: Karol Babioch <karol@babioch.de>
This commit is contained in:
Karol Babioch 2018-10-14 21:58:58 +02:00 • committed by Jouni Malinen
parent 1737eb3982
commit ac1f591567
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/utils/wpa_debug.c
View file

@ -563,6 +563,14 @@ int wpa_debug_open_file(const char *path)
return -1; return -1;
} }
#ifdef __linux__
if (fcntl(out_fd, F_SETFD, FD_CLOEXEC) < 0) {
wpa_printf(MSG_DEBUG,
"%s: Failed to set FD_CLOEXEC - continue without: %s",
__func__, strerror(errno));
}
#endif /* __linux__ */
out_file = fdopen(out_fd, "a"); out_file = fdopen(out_fd, "a");
if (out_file == NULL) { if (out_file == NULL) {
wpa_printf(MSG_ERROR, "wpa_debug_open_file: Failed to open " wpa_printf(MSG_ERROR, "wpa_debug_open_file: Failed to open "