DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

PMKSA: Guard against NULL KCK for memcpy()

Browse source 
If the kck_len is 0 then the pointer may be NULL. If that happens UBSAN
complains about the NULL pointer as memcpy() has the arguments declared
to never be NULL even if the copied number of bytes were zero.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
This commit is contained in:
Benjamin Berg 2024-06-14 10:13:44 +02:00 committed by Jouni Malinen
parent 7bcede06e0
commit ac15b79fe5
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/rsn_supp/pmksa_cache.c
View file

@ -253,7 +253,8 @@ pmksa_cache_add(struct rsn_pmksa_cache *pmksa, const u8 *pmk, size_t pmk_len,
return NULL; return NULL;
os_memcpy(entry->pmk, pmk, pmk_len); os_memcpy(entry->pmk, pmk, pmk_len);
entry->pmk_len = pmk_len; entry->pmk_len = pmk_len;
os_memcpy(entry->kck, kck, kck_len); if (kck_len > 0)
os_memcpy(entry->kck, kck, kck_len);
entry->kck_len = kck_len; entry->kck_len = kck_len;
if (pmkid) if (pmkid)
os_memcpy(entry->pmkid, pmkid, PMKID_LEN); os_memcpy(entry->pmkid, pmkid, PMKID_LEN);