DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Simplify DSCP policy parsing

Browse source 
Make the bounds checking easier for static analyzers to understand.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2022-05-08 17:09:08 +03:00
parent 77bb12a604
commit a6e04a0676
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
wpa_supplicant/robust_av.c
View file

@ -1301,11 +1301,17 @@ void wpas_handle_qos_mgmt_recv_action(struct wpa_supplicant *wpa_s,
attr = qos_ie + 6;
rem_attrs_len = qos_ie[1] - 4;
while (rem_attrs_len > 2 && rem_attrs_len >= 2 + attr[1]) {
wpas_fill_dscp_policy(&policy, attr[0], attr[1],
&attr[2]);
rem_attrs_len -= 2 + attr[1];
attr += 2 + attr[1];
while (rem_attrs_len > 2) {
u8 attr_id, attr_len;
attr_id = *attr++;
attr_len = *attr++;
rem_attrs_len -= 2;
if (attr_len > rem_attrs_len)
break;
wpas_fill_dscp_policy(&policy, attr_id, attr_len, attr);
rem_attrs_len -= attr_len;
attr += attr_len;
}
rem_len -= ie_len;