DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

IBSS RSN: Explicitly check addr != NULL before passing it to memcmp

Browse source 
idx == 0 should be enough to make sure that the addr is set, but
verify that this is indeed the case to avoid any potential issues if
auth_set_key() gets called incorrectly.
This commit is contained in:
Jouni Malinen 2010-01-10 21:53:17 +02:00
parent 2e320d8db5
commit a416fb47eb
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
wpa_supplicant/ibss_rsn.c
View file

@ -261,7 +261,8 @@ static int auth_set_key(void *ctx, int vlan_id, enum wpa_alg alg,
* In IBSS RSN, the pairwise key from the 4-way handshake * In IBSS RSN, the pairwise key from the 4-way handshake
* initiated by the peer with highest MAC address is used. * initiated by the peer with highest MAC address is used.
*/ */
if (os_memcmp(ibss_rsn->wpa_s->own_addr, addr, ETH_ALEN) < 0) { if (addr == NULL ||
os_memcmp(ibss_rsn->wpa_s->own_addr, addr, ETH_ALEN) < 0) {
wpa_printf(MSG_DEBUG, "AUTH: Do not use this PTK"); wpa_printf(MSG_DEBUG, "AUTH: Do not use this PTK");
return 0; return 0;
} }