DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

DPP: Fix dpp_test_gen_invalid_key() with BoringSSL

Browse source 
Unlike OpenSSL, BoringSSL returns an error from
EC_POINT_set_affine_coordinates_GFp() is not on the curve. As such, need
to behave differently here depending on which library is used.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2017-11-18 13:22:17 +02:00 committed by Jouni Malinen
parent d584946ec1
commit 94619905c8
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/common/dpp.c
View file

@ -5842,8 +5842,15 @@ static int dpp_test_gen_invalid_key(struct wpabuf *msg,
goto fail; goto fail;
if (EC_POINT_set_affine_coordinates_GFp(group, point, x, y, if (EC_POINT_set_affine_coordinates_GFp(group, point, x, y,
ctx) != 1) ctx) != 1) {
#ifdef OPENSSL_IS_BORINGSSL
/* Unlike OpenSSL, BoringSSL returns an error from
* EC_POINT_set_affine_coordinates_GFp() is not on the curve. */
break;
#else /* OPENSSL_IS_BORINGSSL */
goto fail; goto fail;
#endif /* OPENSSL_IS_BORINGSSL */
}
if (!EC_POINT_is_on_curve(group, point, ctx)) if (!EC_POINT_is_on_curve(group, point, ctx))
break; break;
@ -5857,6 +5864,8 @@ static int dpp_test_gen_invalid_key(struct wpabuf *msg,
ret = 0; ret = 0;
fail: fail:
if (ret < 0)
wpa_printf(MSG_INFO, "DPP: Failed to generate invalid key");
BN_free(x); BN_free(x);
BN_free(y); BN_free(y);
EC_POINT_free(point); EC_POINT_free(point);