DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

DPP: Report Config Request/Response failure reasons on control interface

Browse source 
This provides more details of failures to upper layer components.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2017-11-03 20:58:53 +02:00 committed by Jouni Malinen
parent f411ad1b86
commit 8c99e6264a
1 changed files with 37 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

77
src/common/dpp.c
View file

@ -3895,16 +3895,15 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
int ap; int ap;
if (dpp_check_attrs(attr_start, attr_len) < 0) { if (dpp_check_attrs(attr_start, attr_len) < 0) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "Invalid attribute in config request");
"DPP: Invalid attribute in config request");
return NULL; return NULL;
} }
wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA, wrapped_data = dpp_get_attr(attr_start, attr_len, DPP_ATTR_WRAPPED_DATA,
&wrapped_data_len); &wrapped_data_len);
if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) { if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing or invalid required Wrapped data attribute"); "Missing or invalid required Wrapped Data attribute");
return NULL; return NULL;
} }
@ -3917,15 +3916,14 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
if (aes_siv_decrypt(auth->ke, auth->curve->hash_len, if (aes_siv_decrypt(auth->ke, auth->curve->hash_len,
wrapped_data, wrapped_data_len, wrapped_data, wrapped_data_len,
0, NULL, NULL, unwrapped) < 0) { 0, NULL, NULL, unwrapped) < 0) {
wpa_printf(MSG_DEBUG, "DPP: AES-SIV decryption failed"); dpp_auth_fail(auth, "AES-SIV decryption failed");
goto fail; goto fail;
} }
wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext", wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
unwrapped, unwrapped_len); unwrapped, unwrapped_len);
if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) { if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "Invalid attribute in unwrapped data");
"DPP: Invalid attribute in unwrapped data");
goto fail; goto fail;
} }
@ -3933,8 +3931,8 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
DPP_ATTR_ENROLLEE_NONCE, DPP_ATTR_ENROLLEE_NONCE,
&e_nonce_len); &e_nonce_len);
if (!e_nonce || e_nonce_len != auth->curve->nonce_len) { if (!e_nonce || e_nonce_len != auth->curve->nonce_len) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing or invalid Enrollee Nonce attribute"); "Missing or invalid Enrollee Nonce attribute");
goto fail; goto fail;
} }
wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len); wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len);
@ -3943,8 +3941,8 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
DPP_ATTR_CONFIG_ATTR_OBJ, DPP_ATTR_CONFIG_ATTR_OBJ,
&config_attr_len); &config_attr_len);
if (!config_attr) { if (!config_attr) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing or invalid Config Attributes attribute"); "Missing or invalid Config Attributes attribute");
goto fail; goto fail;
} }
wpa_hexdump_ascii(MSG_DEBUG, "DPP: Config Attributes", wpa_hexdump_ascii(MSG_DEBUG, "DPP: Config Attributes",
@ -3952,32 +3950,33 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
root = json_parse((const char *) config_attr, config_attr_len); root = json_parse((const char *) config_attr, config_attr_len);
if (!root) { if (!root) {
wpa_printf(MSG_DEBUG, "DPP: Could not parse Config Attributes"); dpp_auth_fail(auth, "Could not parse Config Attributes");
goto fail; goto fail;
} }
token = json_get_member(root, "name"); token = json_get_member(root, "name");
if (!token || token->type != JSON_STRING) { if (!token || token->type != JSON_STRING) {
wpa_printf(MSG_DEBUG, "DPP: No Config Attributes - name"); dpp_auth_fail(auth, "No Config Attributes - name");
goto fail; goto fail;
} }
wpa_printf(MSG_DEBUG, "DPP: Enrollee name = '%s'", token->string); wpa_printf(MSG_DEBUG, "DPP: Enrollee name = '%s'", token->string);
token = json_get_member(root, "wi-fi_tech"); token = json_get_member(root, "wi-fi_tech");
if (!token || token->type != JSON_STRING) { if (!token || token->type != JSON_STRING) {
wpa_printf(MSG_DEBUG, "DPP: No Config Attributes - wi-fi_tech"); dpp_auth_fail(auth, "No Config Attributes - wi-fi_tech");
goto fail; goto fail;
} }
wpa_printf(MSG_DEBUG, "DPP: wi-fi_tech = '%s'", token->string); wpa_printf(MSG_DEBUG, "DPP: wi-fi_tech = '%s'", token->string);
if (os_strcmp(token->string, "infra") != 0) { if (os_strcmp(token->string, "infra") != 0) {
wpa_printf(MSG_DEBUG, "DPP: Unsupported wi-fi_tech '%s'", wpa_printf(MSG_DEBUG, "DPP: Unsupported wi-fi_tech '%s'",
token->string); token->string);
dpp_auth_fail(auth, "Unsupported wi-fi_tech");
goto fail; goto fail;
} }
token = json_get_member(root, "netRole"); token = json_get_member(root, "netRole");
if (!token || token->type != JSON_STRING) { if (!token || token->type != JSON_STRING) {
wpa_printf(MSG_DEBUG, "DPP: No Config Attributes - netRole"); dpp_auth_fail(auth, "No Config Attributes - netRole");
goto fail; goto fail;
} }
wpa_printf(MSG_DEBUG, "DPP: netRole = '%s'", token->string); wpa_printf(MSG_DEBUG, "DPP: netRole = '%s'", token->string);
@ -3988,6 +3987,7 @@ dpp_conf_req_rx(struct dpp_authentication *auth, const u8 *attr_start,
} else { } else {
wpa_printf(MSG_DEBUG, "DPP: Unsupported netRole '%s'", wpa_printf(MSG_DEBUG, "DPP: Unsupported netRole '%s'",
token->string); token->string);
dpp_auth_fail(auth, "Unsupported netRole");
goto fail; goto fail;
} }
@ -4685,38 +4685,37 @@ static int dpp_parse_conf_obj(struct dpp_authentication *auth,
if (!root) if (!root)
return -1; return -1;
if (root->type != JSON_OBJECT) { if (root->type != JSON_OBJECT) {
wpa_printf(MSG_DEBUG, "DPP: JSON root is not an object"); dpp_auth_fail(auth, "JSON root is not an object");
goto fail; goto fail;
} }
token = json_get_member(root, "wi-fi_tech"); token = json_get_member(root, "wi-fi_tech");
if (!token || token->type != JSON_STRING) { if (!token || token->type != JSON_STRING) {
wpa_printf(MSG_DEBUG, "DPP: No wi-fi_tech string value found"); dpp_auth_fail(auth, "No wi-fi_tech string value found");
goto fail; goto fail;
} }
if (os_strcmp(token->string, "infra") != 0) { if (os_strcmp(token->string, "infra") != 0) {
wpa_printf(MSG_DEBUG, "DPP: Unsupported wi-fi_tech value: '%s'", wpa_printf(MSG_DEBUG, "DPP: Unsupported wi-fi_tech value: '%s'",
token->string); token->string);
dpp_auth_fail(auth, "Unsupported wi-fi_tech value");
goto fail; goto fail;
} }
discovery = json_get_member(root, "discovery"); discovery = json_get_member(root, "discovery");
if (!discovery || discovery->type != JSON_OBJECT) { if (!discovery || discovery->type != JSON_OBJECT) {
wpa_printf(MSG_DEBUG, "DPP: No discovery object in JSON"); dpp_auth_fail(auth, "No discovery object in JSON");
goto fail; goto fail;
} }
token = json_get_member(discovery, "ssid"); token = json_get_member(discovery, "ssid");
if (!token || token->type != JSON_STRING) { if (!token || token->type != JSON_STRING) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "No discovery::ssid string value found");
"DPP: No discovery::ssid string value found");
goto fail; goto fail;
} }
wpa_hexdump_ascii(MSG_DEBUG, "DPP: discovery::ssid", wpa_hexdump_ascii(MSG_DEBUG, "DPP: discovery::ssid",
token->string, os_strlen(token->string)); token->string, os_strlen(token->string));
if (os_strlen(token->string) > SSID_MAX_LEN) { if (os_strlen(token->string) > SSID_MAX_LEN) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "Too long discovery::ssid string value");
"DPP: Too long discovery::ssid string value");
goto fail; goto fail;
} }
auth->ssid_len = os_strlen(token->string); auth->ssid_len = os_strlen(token->string);
@ -4724,14 +4723,13 @@ static int dpp_parse_conf_obj(struct dpp_authentication *auth,
cred = json_get_member(root, "cred"); cred = json_get_member(root, "cred");
if (!cred || cred->type != JSON_OBJECT) { if (!cred || cred->type != JSON_OBJECT) {
wpa_printf(MSG_DEBUG, "DPP: No cred object in JSON"); dpp_auth_fail(auth, "No cred object in JSON");
goto fail; goto fail;
} }
token = json_get_member(cred, "akm"); token = json_get_member(cred, "akm");
if (!token || token->type != JSON_STRING) { if (!token || token->type != JSON_STRING) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "No cred::akm string value found");
"DPP: No cred::akm string value found");
goto fail; goto fail;
} }
if (os_strcmp(token->string, "psk") == 0) { if (os_strcmp(token->string, "psk") == 0) {
@ -4743,6 +4741,7 @@ static int dpp_parse_conf_obj(struct dpp_authentication *auth,
} else { } else {
wpa_printf(MSG_DEBUG, "DPP: Unsupported akm: %s", wpa_printf(MSG_DEBUG, "DPP: Unsupported akm: %s",
token->string); token->string);
dpp_auth_fail(auth, "Unsupported akm");
goto fail; goto fail;
} }
@ -4766,8 +4765,7 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
int ret = -1; int ret = -1;
if (dpp_check_attrs(wpabuf_head(resp), wpabuf_len(resp)) < 0) { if (dpp_check_attrs(wpabuf_head(resp), wpabuf_len(resp)) < 0) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "Invalid attribute in config response");
"DPP: Invalid attribute in config response");
return -1; return -1;
} }
@ -4775,8 +4773,8 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
DPP_ATTR_WRAPPED_DATA, DPP_ATTR_WRAPPED_DATA,
&wrapped_data_len); &wrapped_data_len);
if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) { if (!wrapped_data || wrapped_data_len < AES_BLOCK_SIZE) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing or invalid required Wrapped data attribute"); "Missing or invalid required Wrapped Data attribute");
return -1; return -1;
} }
@ -4794,15 +4792,14 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
if (aes_siv_decrypt(auth->ke, auth->curve->hash_len, if (aes_siv_decrypt(auth->ke, auth->curve->hash_len,
wrapped_data, wrapped_data_len, wrapped_data, wrapped_data_len,
1, addr, len, unwrapped) < 0) { 1, addr, len, unwrapped) < 0) {
wpa_printf(MSG_DEBUG, "DPP: AES-SIV decryption failed"); dpp_auth_fail(auth, "AES-SIV decryption failed");
goto fail; goto fail;
} }
wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext", wpa_hexdump(MSG_DEBUG, "DPP: AES-SIV cleartext",
unwrapped, unwrapped_len); unwrapped, unwrapped_len);
if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) { if (dpp_check_attrs(unwrapped, unwrapped_len) < 0) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth, "Invalid attribute in unwrapped data");
"DPP: Invalid attribute in unwrapped data");
goto fail; goto fail;
} }
@ -4810,34 +4807,34 @@ int dpp_conf_resp_rx(struct dpp_authentication *auth,
DPP_ATTR_ENROLLEE_NONCE, DPP_ATTR_ENROLLEE_NONCE,
&e_nonce_len); &e_nonce_len);
if (!e_nonce || e_nonce_len != auth->curve->nonce_len) { if (!e_nonce || e_nonce_len != auth->curve->nonce_len) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing or invalid Enrollee Nonce attribute"); "Missing or invalid Enrollee Nonce attribute");
goto fail; goto fail;
} }
wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len); wpa_hexdump(MSG_DEBUG, "DPP: Enrollee Nonce", e_nonce, e_nonce_len);
if (os_memcmp(e_nonce, auth->e_nonce, e_nonce_len) != 0) { if (os_memcmp(e_nonce, auth->e_nonce, e_nonce_len) != 0) {
wpa_printf(MSG_DEBUG, "Enrollee Nonce mismatch"); dpp_auth_fail(auth, "Enrollee Nonce mismatch");
goto fail; goto fail;
} }
status = dpp_get_attr(wpabuf_head(resp), wpabuf_len(resp), status = dpp_get_attr(wpabuf_head(resp), wpabuf_len(resp),
DPP_ATTR_STATUS, &status_len); DPP_ATTR_STATUS, &status_len);
if (!status || status_len < 1) { if (!status || status_len < 1) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing or invalid required DPP Status attribute"); "Missing or invalid required DPP Status attribute");
goto fail; goto fail;
} }
wpa_printf(MSG_DEBUG, "DPP: Status %u", status[0]); wpa_printf(MSG_DEBUG, "DPP: Status %u", status[0]);
if (status[0] != DPP_STATUS_OK) { if (status[0] != DPP_STATUS_OK) {
wpa_printf(MSG_DEBUG, "DPP: Configuration failed"); dpp_auth_fail(auth, "Configurator rejected configuration");
goto fail; goto fail;
} }
conf_obj = dpp_get_attr(unwrapped, unwrapped_len, conf_obj = dpp_get_attr(unwrapped, unwrapped_len,
DPP_ATTR_CONFIG_OBJ, &conf_obj_len); DPP_ATTR_CONFIG_OBJ, &conf_obj_len);
if (!conf_obj) { if (!conf_obj) {
wpa_printf(MSG_DEBUG, dpp_auth_fail(auth,
"DPP: Missing required Configuration Object attribute"); "Missing required Configuration Object attribute");
goto fail; goto fail;
} }
wpa_hexdump_ascii(MSG_DEBUG, "DPP: configurationObject JSON", wpa_hexdump_ascii(MSG_DEBUG, "DPP: configurationObject JSON",