DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

nl80211: Fix potential NULL pointer dereference in set_ap()

Browse source 
In the code review, it was found that param->freq is accessed without
NULL check in wpa_driver_nl80211_set_ap(), while in other sections of
the code, freq is accessed only after NULL validation. This situation
could result in a segmentation fault at least in theory.

Add a NULL check for freq before accessing it to be consistent with the
other uses.

Fixes: 0c6c948047 ("nl80211: Support setting up an AP on a specified link")
Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
This commit is contained in:
Karthikeyan Kathirvel 2024-03-05 12:39:44 +05:30 committed by Jouni Malinen
parent 666e954ca2
commit 69d53b8b6b
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/drivers/driver_nl80211.c
View file

@ -5109,8 +5109,9 @@ static int wpa_driver_nl80211_set_ap(void *priv,
nl80211_put_freq_params(msg, params->freq) < 0))
goto fail;
nl80211_link_set_freq(bss, params->mld_link_id,
params->freq->freq);
if (params->freq)
nl80211_link_set_freq(bss, params->mld_link_id,
params->freq->freq);
}
if (params->proberesp && params->proberesp_len) {