DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

MBO: Fix the allowed range of mbo_assoc_disallow values

Browse source 
This parameter was added with the commit message indicating the valid
reason code values to be 1-5, but with the implementation allowed only
1. There are five defined reason code values for the Association
Disallowed attribute, so extend the allowed range to cover all those
values.

Fixes: fb9a1c3e28 ("hostapd: Add MBO IE to Beacon, Probe Response, Association Response")
Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
This commit is contained in:
Janusz Dziedzic 2021-10-24 21:48:34 +02:00 committed by Jouni Malinen
parent c8e4283f90
commit 5530688b92
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hostapd/ctrl_iface.c
View file

@ -1504,7 +1504,7 @@ static int hostapd_ctrl_iface_set(struct hostapd_data *hapd, char *cmd)
return -1; return -1;
val = atoi(value); val = atoi(value);
if (val < 0 || val > 1) if (val < 0 || val > MBO_ASSOC_DISALLOW_REASON_LOW_RSSI)
return -1; return -1;
hapd->mbo_assoc_disallow = val; hapd->mbo_assoc_disallow = val;

4
tests/hwsim/test_mbo.py
View file

@ -203,8 +203,8 @@ def test_mbo_assoc_disallow(dev, apdev, params):
hapd2 = hostapd.add_ap(apdev[1], {"ssid": "MBO", "mbo": "1"}) hapd2 = hostapd.add_ap(apdev[1], {"ssid": "MBO", "mbo": "1"})
logger.debug("Set mbo_assoc_disallow with invalid value") logger.debug("Set mbo_assoc_disallow with invalid value")
if "FAIL" not in hapd1.request("SET mbo_assoc_disallow 2"): if "FAIL" not in hapd1.request("SET mbo_assoc_disallow 6"):
raise Exception("Set mbo_assoc_disallow for AP1 succeeded unexpectedly with value 2") raise Exception("Set mbo_assoc_disallow for AP1 succeeded unexpectedly with value 6")
logger.debug("Disallow associations to AP1 and allow association to AP2") logger.debug("Disallow associations to AP1 and allow association to AP2")
if "OK" not in hapd1.request("SET mbo_assoc_disallow 1"): if "OK" not in hapd1.request("SET mbo_assoc_disallow 1"):