DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

trace: Use strncmp() to match function names

Browse source 
The functions specified by the user might be longer than the function in
the backtrace, potentially overflowing the memcmp(). In practice, it
should not be a relevant out-of-memory read. However, we can use
strncmp() instead.

Note that, as before, this is only a prefix match. If a function name is
longer in the backtrace it will still match.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
This commit is contained in:
Benjamin Berg 2024-06-14 10:13:49 +02:00 committed by Jouni Malinen
parent 918da644e1
commit 49344db095
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/utils/os_unix.c
View file

@ -611,7 +611,7 @@ int testing_test_fail(const char *tag, bool is_alloc)
len = next - pos; len = next - pos;
else else
len = os_strlen(pos); len = os_strlen(pos);
if (os_memcmp(pos, func[i], len) != 0) { if (os_strncmp(pos, func[i], len) != 0) {
if (maybe && next) { if (maybe && next) {
pos = next + 1; pos = next + 1;
continue; continue;