Simplify VHT Capabilities element parsing
Check the element length in the parser and remove the length field from struct ieee802_11_elems since the element is of fixed length. Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
parent
baae4cb9b4
commit
40baac0e43
8 changed files with 9 additions and 13 deletions
|
@ -1603,9 +1603,7 @@ static int copy_peer_ht_capab(const struct wpa_eapol_ie_parse *kde,
|
|||
static int copy_peer_vht_capab(const struct wpa_eapol_ie_parse *kde,
|
||||
struct wpa_tdls_peer *peer)
|
||||
{
|
||||
if (!kde->vht_capabilities ||
|
||||
kde->vht_capabilities_len <
|
||||
sizeof(struct ieee80211_vht_capabilities) ) {
|
||||
if (!kde->vht_capabilities) {
|
||||
wpa_printf(MSG_DEBUG, "TDLS: No supported vht capabilities "
|
||||
"received");
|
||||
return 0;
|
||||
|
|
|
@ -559,9 +559,10 @@ int wpa_supplicant_parse_ies(const u8 *buf, size_t len,
|
|||
} else if (*pos == WLAN_EID_VHT_AID) {
|
||||
if (pos[1] >= 2)
|
||||
ie->aid = WPA_GET_LE16(pos + 2) & 0x3fff;
|
||||
} else if (*pos == WLAN_EID_VHT_CAP) {
|
||||
} else if (*pos == WLAN_EID_VHT_CAP &&
|
||||
pos[1] >= sizeof(struct ieee80211_vht_capabilities))
|
||||
{
|
||||
ie->vht_capabilities = pos + 2;
|
||||
ie->vht_capabilities_len = pos[1];
|
||||
} else if (*pos == WLAN_EID_QOS && pos[1] >= 1) {
|
||||
ie->qosinfo = pos[2];
|
||||
} else if (*pos == WLAN_EID_SUPPORTED_CHANNELS) {
|
||||
|
|
|
@ -51,7 +51,6 @@ struct wpa_eapol_ie_parse {
|
|||
size_t ext_supp_rates_len;
|
||||
const u8 *ht_capabilities;
|
||||
const u8 *vht_capabilities;
|
||||
size_t vht_capabilities_len;
|
||||
const u8 *supp_channels;
|
||||
size_t supp_channels_len;
|
||||
const u8 *supp_oper_classes;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue