DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Check hmac_md5() result in radius_msg_verify_msg_auth()

Browse source 
This gets rid of a valgrind warning on uninitialized memory read in the
hostapd_oom_wpa2_eap_connect test case where memcmp is used after failed
hmac_md5() call.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2016-05-16 20:06:46 +03:00 committed by Jouni Malinen
parent 05dad946b3
commit 38eee0f599
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/radius/radius.c
View file

@ -818,8 +818,9 @@ int radius_msg_verify_msg_auth(struct radius_msg *msg, const u8 *secret,
os_memcpy(msg->hdr->authenticator, req_auth, os_memcpy(msg->hdr->authenticator, req_auth,
sizeof(msg->hdr->authenticator)); sizeof(msg->hdr->authenticator));
} }
hmac_md5(secret, secret_len, wpabuf_head(msg->buf), if (hmac_md5(secret, secret_len, wpabuf_head(msg->buf),
wpabuf_len(msg->buf), auth); wpabuf_len(msg->buf), auth) < 0)
return 1;
os_memcpy(attr + 1, orig, MD5_MAC_LEN); os_memcpy(attr + 1, orig, MD5_MAC_LEN);
if (req_auth) { if (req_auth) {
os_memcpy(msg->hdr->authenticator, orig_authenticator, os_memcpy(msg->hdr->authenticator, orig_authenticator,