DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

ACS: More consistent checking of the best channel pointer

Browse source 
It looks like best might be NULL in some cases, so check for this
explicitly before trying to dereference it for a debug print.

Fixes: 733de85680 ("ACS: Fix not selecting the best channel in the segment")
Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
This commit is contained in:
Jouni Malinen 2024-01-22 21:58:06 +02:00 • committed by Jouni Malinen
parent 5d54bf6fb6
commit 348c047afd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ap/acs.c
View file

@ -963,7 +963,7 @@ acs_find_ideal_chan_mode(struct hostapd_iface *iface,
* crowded primary channel if one was found in the segment */ * crowded primary channel if one was found in the segment */
if (iface->current_mode && if (iface->current_mode &&
iface->current_mode->mode == HOSTAPD_MODE_IEEE80211A && iface->current_mode->mode == HOSTAPD_MODE_IEEE80211A &&
chan != best) { best && chan != best) {
wpa_printf(MSG_DEBUG, wpa_printf(MSG_DEBUG,
"ACS: promoting channel %d over %d (less interference %Lg/%Lg)", "ACS: promoting channel %d over %d (less interference %Lg/%Lg)",
best->chan, chan->chan, best->chan, chan->chan,