DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Check md5_vector() result in decrypt_ms_key()

Browse source 
This gets rid of a valgrind warning on uninitialized memory read in the
hostapd_oom_wpa2_eap_connect test case where the result is used after
failed md5_vector() call.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2016-05-16 20:08:53 +03:00 committed by Jouni Malinen
parent 38eee0f599
commit 2c3d95c7e0
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/radius/radius.c
View file

@ -1018,7 +1018,10 @@ static u8 * decrypt_ms_key(const u8 *key, size_t len,
addr[1] = pos - MD5_MAC_LEN; addr[1] = pos - MD5_MAC_LEN;
elen[1] = MD5_MAC_LEN; elen[1] = MD5_MAC_LEN;
} }
md5_vector(first ? 3 : 2, addr, elen, hash); if (md5_vector(first ? 3 : 2, addr, elen, hash) < 0) {
os_free(plain);
return NULL;
}
first = 0; first = 0;
for (i = 0; i < MD5_MAC_LEN; i++) for (i = 0; i < MD5_MAC_LEN; i++)