DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

EAP-TNC: Add Flags field into fragment acknowledgement

Browse source 
TNC IF-T is somewhat unclear on this are, but
draft-hanna-nea-pt-eap-00.txt, which is supposed to define the same
protocol, is clearer on the Flags field being included.

This change breaks interoperability with the old implementation if
EAP-TNC fragmentation is used. The old version would not accept
the acknowledgement message with the added Flags octet while the
new version accepts messagss with with both options.
This commit is contained in:
Jouni Malinen 2010-02-14 16:08:15 +02:00
parent 4a3ade4e11
commit 25ac1328f6
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/eap_peer/eap_tnc.c
View file

@ -73,12 +73,13 @@ static struct wpabuf * eap_tnc_build_frag_ack(u8 id, u8 code)
{ {
struct wpabuf *msg; struct wpabuf *msg;
msg = eap_msg_alloc(EAP_VENDOR_IETF, EAP_TYPE_TNC, 0, code, id); msg = eap_msg_alloc(EAP_VENDOR_IETF, EAP_TYPE_TNC, 1, code, id);
if (msg == NULL) { if (msg == NULL) {
wpa_printf(MSG_ERROR, "EAP-TNC: Failed to allocate memory " wpa_printf(MSG_ERROR, "EAP-TNC: Failed to allocate memory "
"for fragment ack"); "for fragment ack");
return NULL; return NULL;
} }
wpabuf_put_u8(msg, EAP_TNC_VERSION); /* Flags */
wpa_printf(MSG_DEBUG, "EAP-TNC: Send fragment ack"); wpa_printf(MSG_DEBUG, "EAP-TNC: Send fragment ack");

3
src/eap_server/eap_tnc.c
View file

@ -173,12 +173,13 @@ static struct wpabuf * eap_tnc_build_frag_ack(u8 id, u8 code)
{ {
struct wpabuf *msg; struct wpabuf *msg;
msg = eap_msg_alloc(EAP_VENDOR_IETF, EAP_TYPE_TNC, 0, code, id); msg = eap_msg_alloc(EAP_VENDOR_IETF, EAP_TYPE_TNC, 1, code, id);
if (msg == NULL) { if (msg == NULL) {
wpa_printf(MSG_ERROR, "EAP-TNC: Failed to allocate memory " wpa_printf(MSG_ERROR, "EAP-TNC: Failed to allocate memory "
"for fragment ack"); "for fragment ack");
return NULL; return NULL;
} }
wpabuf_put_u8(msg, EAP_TNC_VERSION); /* Flags */
wpa_printf(MSG_DEBUG, "EAP-TNC: Send fragment ack"); wpa_printf(MSG_DEBUG, "EAP-TNC: Send fragment ack");