DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

dbus: Move roam metrics to the correct interface

Browse source 
These properties were in the wpas_dbus_bss_properties array when they
should have been in the wpas_dbus_interface_properties array. Move them
to the right place. This is the logical location for these properties
and it matches both the other parts of the implementation (e.g., being
in enum wpas_dbus_prop, not in enum wpas_dbus_bss_prop) and what
was originally documented for the interface in dbus.doxygen.

Fixes: 2bbad1c7c9 ("dbus: Export roam time, roam complete, and session length")
Fixes: 80d06d0ca9 ("dbus: Export BSS Transition Management status")
Signed-off-by: Matthew Wang <matthewmwang@chromium.org>
This commit is contained in:
Matthew Wang 2019-10-11 13:49:25 -07:00 committed by Jouni Malinen
parent 8e111157e7
commit 23d87687c2
1 changed files with 24 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
wpa_supplicant/dbus/dbus_new.c
View file

@ -2855,30 +2855,6 @@ static const struct wpa_dbus_property_desc wpas_dbus_bss_properties[] = {
NULL, NULL,
NULL NULL
}, },
{
"RoamTime", WPAS_DBUS_NEW_IFACE_INTERFACE, "u",
wpas_dbus_getter_roam_time,
NULL,
NULL
},
{
"RoamComplete", WPAS_DBUS_NEW_IFACE_INTERFACE, "b",
wpas_dbus_getter_roam_complete,
NULL,
NULL
},
{
"SessionLength", WPAS_DBUS_NEW_IFACE_INTERFACE, "u",
wpas_dbus_getter_session_length,
NULL,
NULL
},
{
"BSSTMStatus", WPAS_DBUS_NEW_IFACE_INTERFACE, "u",
wpas_dbus_getter_bss_tm_status,
NULL,
NULL
},
{ NULL, NULL, NULL, NULL, NULL, NULL } { NULL, NULL, NULL, NULL, NULL, NULL }
}; };
@ -3786,6 +3762,30 @@ static const struct wpa_dbus_property_desc wpas_dbus_interface_properties[] = {
NULL, NULL,
NULL NULL
}, },
{
"RoamTime", WPAS_DBUS_NEW_IFACE_INTERFACE, "u",
wpas_dbus_getter_roam_time,
NULL,
NULL
},
{
"RoamComplete", WPAS_DBUS_NEW_IFACE_INTERFACE, "b",
wpas_dbus_getter_roam_complete,
NULL,
NULL
},
{
"SessionLength", WPAS_DBUS_NEW_IFACE_INTERFACE, "u",
wpas_dbus_getter_session_length,
NULL,
NULL
},
{
"BSSTMStatus", WPAS_DBUS_NEW_IFACE_INTERFACE, "u",
wpas_dbus_getter_bss_tm_status,
NULL,
NULL
},
#ifdef CONFIG_MESH #ifdef CONFIG_MESH
{ "MeshPeers", WPAS_DBUS_NEW_IFACE_MESH, "aay", { "MeshPeers", WPAS_DBUS_NEW_IFACE_MESH, "aay",
wpas_dbus_getter_mesh_peers, wpas_dbus_getter_mesh_peers,