DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Move wpa_sm_remove_pmkid() call to PMKSA cache entry freeing

Browse source 
This makes it clearer that the PMKSA caching entry gets removed from
the driver regardless of how the internal entry from wpa_supplicant
gets cleared. In practice, this call was skipped only for the case
when the entry for the current AP was being updated, so the previous
version was likely to work with all drivers. Anyway, it is cleaner
to explicitly remove the old entry even in that case before the new
entry gets added.

Signed-hostap: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2011-11-20 12:53:29 +02:00
parent bf689a409f
commit 1323ee314e
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/rsn_supp/pmksa_cache.c
View file

@ -49,6 +49,7 @@ static void pmksa_cache_free_entry(struct rsn_pmksa_cache *pmksa,
struct rsn_pmksa_cache_entry *entry, struct rsn_pmksa_cache_entry *entry,
int replace) int replace)
{ {
wpa_sm_remove_pmkid(pmksa->sm, entry->aa, entry->pmkid);
pmksa->pmksa_count--; pmksa->pmksa_count--;
pmksa->free_cb(entry, pmksa->ctx, replace); pmksa->free_cb(entry, pmksa->ctx, replace);
_pmksa_cache_free_entry(entry); _pmksa_cache_free_entry(entry);
@ -66,7 +67,6 @@ static void pmksa_cache_expire(void *eloop_ctx, void *timeout_ctx)
pmksa->pmksa = entry->next; pmksa->pmksa = entry->next;
wpa_printf(MSG_DEBUG, "RSN: expired PMKSA cache entry for " wpa_printf(MSG_DEBUG, "RSN: expired PMKSA cache entry for "
MACSTR, MAC2STR(entry->aa)); MACSTR, MAC2STR(entry->aa));
wpa_sm_remove_pmkid(pmksa->sm, entry->aa, entry->pmkid);
pmksa_cache_free_entry(pmksa, entry, 0); pmksa_cache_free_entry(pmksa, entry, 0);
} }
@ -207,7 +207,6 @@ pmksa_cache_add(struct rsn_pmksa_cache *pmksa, const u8 *pmk, size_t pmk_len,
wpa_printf(MSG_DEBUG, "RSN: removed the oldest PMKSA cache " wpa_printf(MSG_DEBUG, "RSN: removed the oldest PMKSA cache "
"entry (for " MACSTR ") to make room for new one", "entry (for " MACSTR ") to make room for new one",
MAC2STR(pos->aa)); MAC2STR(pos->aa));
wpa_sm_remove_pmkid(pmksa->sm, pos->aa, pos->pmkid);
pmksa_cache_free_entry(pmksa, pos, 0); pmksa_cache_free_entry(pmksa, pos, 0);
} }
@ -258,7 +257,6 @@ void pmksa_cache_flush(struct rsn_pmksa_cache *pmksa, void *network_ctx)
pmksa->pmksa = entry->next; pmksa->pmksa = entry->next;
tmp = entry; tmp = entry;
entry = entry->next; entry = entry->next;
wpa_sm_remove_pmkid(pmksa->sm, tmp->aa, tmp->pmkid);
pmksa_cache_free_entry(pmksa, tmp, 0); pmksa_cache_free_entry(pmksa, tmp, 0);
removed++; removed++;
} else { } else {