DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

hostapd: Do not use prefix matching for ENABLE/RELOAD/DISABLE

Browse source 
These control interface commands do not take any parameters and as such,
do not need to use a prefix match. Replace that with an exact string
match to avoid matching other potential command strings.

Fixes: 7554565299 ("hostapd: Add ctrl_iface for enabling/reloading/disabling interface")
Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
This commit is contained in:
Jouni Malinen 2024-02-02 22:26:29 +02:00 committed by Jouni Malinen
parent 03e89de47b
commit 0102c5c606
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
hostapd/ctrl_iface.c
View file

@ -3666,7 +3666,7 @@ static int hostapd_ctrl_iface_receive_process(struct hostapd_data *hapd,
} else if (os_strncmp(buf, "GET ", 4) == 0) { } else if (os_strncmp(buf, "GET ", 4) == 0) {
reply_len = hostapd_ctrl_iface_get(hapd, buf + 4, reply, reply_len = hostapd_ctrl_iface_get(hapd, buf + 4, reply,
reply_size); reply_size);
} else if (os_strncmp(buf, "ENABLE", 6) == 0) { } else if (os_strcmp(buf, "ENABLE") == 0) {
if (hostapd_ctrl_iface_enable(hapd->iface)) if (hostapd_ctrl_iface_enable(hapd->iface))
reply_len = -1; reply_len = -1;
} else if (os_strcmp(buf, "RELOAD_WPA_PSK") == 0) { } else if (os_strcmp(buf, "RELOAD_WPA_PSK") == 0) {
@ -3686,10 +3686,10 @@ static int hostapd_ctrl_iface_receive_process(struct hostapd_data *hapd,
} else if (os_strcmp(buf, "RELOAD_CONFIG") == 0) { } else if (os_strcmp(buf, "RELOAD_CONFIG") == 0) {
if (hostapd_reload_config(hapd->iface)) if (hostapd_reload_config(hapd->iface))
reply_len = -1; reply_len = -1;
} else if (os_strncmp(buf, "RELOAD", 6) == 0) { } else if (os_strcmp(buf, "RELOAD") == 0) {
if (hostapd_ctrl_iface_reload(hapd->iface)) if (hostapd_ctrl_iface_reload(hapd->iface))
reply_len = -1; reply_len = -1;
} else if (os_strncmp(buf, "DISABLE", 7) == 0) { } else if (os_strcmp(buf, "DISABLE") == 0) {
if (hostapd_ctrl_iface_disable(hapd->iface)) if (hostapd_ctrl_iface_disable(hapd->iface))
reply_len = -1; reply_len = -1;
} else if (os_strcmp(buf, "UPDATE_BEACON") == 0) { } else if (os_strcmp(buf, "UPDATE_BEACON") == 0) {