- KFetConfig `set` method now takes model instance instead of their pk for this type of entries. - Add tests for KFetConfig class: tests against types currently used by kfet app (duration, modelinstance, decimal). - These tests are located in `kfet/tests/test_config.py`. We should separate tests suites by file like this, considering what they are about. - KFetConfig method `set_many` renamed to `set` (because it also updates only one).
67 lines
1.8 KiB
Python
67 lines
1.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from django.core.exceptions import ValidationError
|
|
from django.db import models
|
|
|
|
from djconfig import config
|
|
|
|
|
|
class KFetConfig(object):
|
|
"""kfet app configuration.
|
|
|
|
Enhance isolation with backend used to store config.
|
|
Usable after DjConfig middleware was called.
|
|
|
|
"""
|
|
prefix = 'kfet_'
|
|
|
|
def __getattr__(self, key):
|
|
return getattr(config, self._get_dj_key(key))
|
|
|
|
def list(self):
|
|
"""Get list of kfet app configuration.
|
|
|
|
Returns:
|
|
(key, value) for each configuration entry as list.
|
|
|
|
"""
|
|
# prevent circular imports
|
|
from kfet.forms import KFetConfigForm
|
|
return [(field.label, getattr(config, name), )
|
|
for name, field in KFetConfigForm.base_fields.items()]
|
|
|
|
def _get_dj_key(self, key):
|
|
return '{}{}'.format(self.prefix, key)
|
|
|
|
def set(self, **kwargs):
|
|
"""Update configuration value(s).
|
|
|
|
Args:
|
|
**kwargs: Keyword arguments. Keys must be in kfet config.
|
|
Config entries are updated to given values.
|
|
|
|
"""
|
|
# prevent circular imports
|
|
from kfet.forms import KFetConfigForm
|
|
|
|
# get old config
|
|
new_cfg = KFetConfigForm().initial
|
|
# update to new config
|
|
for key, value in kwargs.items():
|
|
dj_key = self._get_dj_key(key)
|
|
if isinstance(value, models.Model):
|
|
new_cfg[dj_key] = value.pk
|
|
else:
|
|
new_cfg[dj_key] = value
|
|
# save new config
|
|
cfg_form = KFetConfigForm(new_cfg)
|
|
if cfg_form.is_valid():
|
|
cfg_form.save()
|
|
else:
|
|
raise ValidationError(
|
|
'Invalid values in kfet_config.set: %(fields)s',
|
|
params={'fields': list(cfg_form.errors)})
|
|
|
|
|
|
kfet_config = KFetConfig()
|