2018-10-06 03:14:49 +02:00
|
|
|
#!/usr/bin/env bash
|
|
|
|
# pre-commit hook for gestioCOF project.
|
|
|
|
#
|
|
|
|
# Run formatters first, then checkers.
|
|
|
|
# Formatters which changed a file must set the flag 'formatter_updated'.
|
|
|
|
|
|
|
|
exit_code=0
|
|
|
|
formatter_updated=0
|
|
|
|
checker_dirty=0
|
|
|
|
|
|
|
|
# TODO(AD): We should check only staged changes.
|
|
|
|
# Working? -> Stash unstaged changes, run it, pop stash
|
|
|
|
STAGED_PYTHON_FILES=$(git diff --cached --name-only --diff-filter=ACM | grep ".py$")
|
|
|
|
|
2018-10-06 23:57:33 +02:00
|
|
|
|
2018-10-06 03:14:49 +02:00
|
|
|
# Formatter: black
|
|
|
|
|
|
|
|
printf "> black ... "
|
|
|
|
|
|
|
|
if type black &>/dev/null; then
|
2018-10-06 15:50:49 +02:00
|
|
|
if [ -z "$STAGED_PYTHON_FILES" ]; then
|
2018-10-06 03:14:49 +02:00
|
|
|
printf "OK\n"
|
|
|
|
else
|
|
|
|
BLACK_OUTPUT="/tmp/gc-black-output.log"
|
|
|
|
touch $BLACK_OUTPUT
|
|
|
|
|
2018-10-06 23:57:33 +02:00
|
|
|
if ! echo "$STAGED_PYTHON_FILES" | xargs -d'\n' black --check &>$BLACK_OUTPUT; then
|
|
|
|
echo "$STAGED_PYTHON_FILES" | xargs -d'\n' black &>$BLACK_OUTPUT
|
2018-10-06 03:14:49 +02:00
|
|
|
tail -1 $BLACK_OUTPUT
|
|
|
|
formatter_updated=1
|
2018-10-06 15:50:49 +02:00
|
|
|
else
|
|
|
|
printf "OK\n"
|
2018-10-06 03:14:49 +02:00
|
|
|
fi
|
|
|
|
fi
|
|
|
|
else
|
|
|
|
printf "SKIP: program not found\n"
|
|
|
|
printf "HINT: Install black with 'pip3 install black' (black requires Python>=3.6)\n"
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Formatter: isort
|
|
|
|
|
|
|
|
printf "> isort ... "
|
|
|
|
|
|
|
|
if type isort &>/dev/null; then
|
2018-10-06 15:50:49 +02:00
|
|
|
if [ -z "$STAGED_PYTHON_FILES" ]; then
|
2018-10-06 03:14:49 +02:00
|
|
|
printf "OK\n"
|
|
|
|
else
|
|
|
|
ISORT_OUTPUT="/tmp/gc-isort-output.log"
|
|
|
|
touch $ISORT_OUTPUT
|
|
|
|
|
2018-10-06 23:57:33 +02:00
|
|
|
if ! echo "$STAGED_PYTHON_FILES" | xargs -d'\n' isort --check-only &>$ISORT_OUTPUT; then
|
|
|
|
echo "$STAGED_PYTHON_FILES" | xargs -d'\n' isort &>$ISORT_OUTPUT
|
2018-10-06 03:14:49 +02:00
|
|
|
printf "Reformatted.\n"
|
|
|
|
formatter_updated=1
|
2018-10-06 15:50:49 +02:00
|
|
|
else
|
|
|
|
printf "OK\n"
|
2018-10-06 03:14:49 +02:00
|
|
|
fi
|
|
|
|
fi
|
|
|
|
else
|
|
|
|
printf "SKIP: program not found\n"
|
|
|
|
printf "HINT: Install isort with 'pip install isort'\n"
|
|
|
|
fi
|
|
|
|
|
|
|
|
# Checker: flake8
|
|
|
|
|
|
|
|
printf "> flake8 ... "
|
|
|
|
|
|
|
|
if type flake8 &>/dev/null; then
|
2018-10-06 15:50:49 +02:00
|
|
|
if [ -z "$STAGED_PYTHON_FILES" ]; then
|
2018-10-06 03:14:49 +02:00
|
|
|
printf "OK\n"
|
|
|
|
else
|
|
|
|
FLAKE8_OUTPUT="/tmp/gc-flake8-output.log"
|
|
|
|
touch $FLAKE8_OUTPUT
|
|
|
|
|
2018-10-06 23:57:33 +02:00
|
|
|
if ! echo "$STAGED_PYTHON_FILES" | xargs -d'\n' flake8 &>$FLAKE8_OUTPUT; then
|
2018-10-06 03:14:49 +02:00
|
|
|
printf "FAIL\n"
|
|
|
|
cat $FLAKE8_OUTPUT
|
|
|
|
checker_dirty=1
|
2018-10-06 15:50:49 +02:00
|
|
|
else
|
|
|
|
printf "OK\n"
|
2018-10-06 03:14:49 +02:00
|
|
|
fi
|
|
|
|
fi
|
|
|
|
else
|
|
|
|
printf "SKIP: program not found\n"
|
|
|
|
printf "HINT: Install flake8 with 'pip install flake8'\n"
|
|
|
|
fi
|
|
|
|
|
|
|
|
# End
|
|
|
|
|
|
|
|
if [ $checker_dirty -ne 0 ]
|
|
|
|
then
|
|
|
|
printf ">>> Checker(s) detect(s) issue(s)\n"
|
|
|
|
printf " You can still commit and push :)\n"
|
|
|
|
printf " Be warned that our CI may cause you more trouble.\n"
|
|
|
|
fi
|
|
|
|
|
|
|
|
if [ $formatter_updated -ne 0 ]
|
|
|
|
then
|
|
|
|
printf ">>> Working tree updated by formatter(s)\n"
|
|
|
|
printf " Add changes to staging area and retry.\n"
|
|
|
|
exit_code=1
|
|
|
|
fi
|
|
|
|
|
|
|
|
printf "\n"
|
|
|
|
|
|
|
|
exit $exit_code
|