970e43efb8
tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?
feat(stats): add DeletedDossier in Stat computations
Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?"
This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089.
feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos
clean(rubocop): lint with rubocop
Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
fix(rubocop): avoid uneeded allocation
fix(migration): add concurrent index with expected synthax
fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself
148 lines
5.9 KiB
Text
148 lines
5.9 KiB
Text
{
|
|
"ignored_warnings": [
|
|
{
|
|
"warning_type": "Cross-Site Scripting",
|
|
"warning_code": 2,
|
|
"fingerprint": "42099f4550a8377f455e830e8ab645cecd5806248481c5c646b4e17548c3cb07",
|
|
"check_name": "CrossSiteScripting",
|
|
"message": "Unescaped model attribute",
|
|
"file": "app/views/france_connect/particulier/merge.html.haml",
|
|
"line": 6,
|
|
"link": "https://brakemanscanner.org/docs/warning_types/cross_site_scripting",
|
|
"code": "t(\".subtitle\", :email => sanitize(FranceConnectInformation.find_by(:merge_token => merge_token_params).email_france_connect), :application_name => (APPLICATION_NAME))",
|
|
"render_path": [
|
|
{
|
|
"type": "controller",
|
|
"class": "FranceConnect::ParticulierController",
|
|
"method": "merge",
|
|
"line": 48,
|
|
"file": "app/controllers/france_connect/particulier_controller.rb",
|
|
"rendered": {
|
|
"name": "france_connect/particulier/merge",
|
|
"file": "app/views/france_connect/particulier/merge.html.haml"
|
|
}
|
|
}
|
|
],
|
|
"location": {
|
|
"type": "template",
|
|
"template": "france_connect/particulier/merge"
|
|
},
|
|
"user_input": "FranceConnectInformation.find_by(:merge_token => merge_token_params).email_france_connect",
|
|
"confidence": "Weak",
|
|
"note": "explicitely sanitized even if we are using html_safe"
|
|
},
|
|
{
|
|
"warning_type": "Cross-Site Scripting",
|
|
"warning_code": 2,
|
|
"fingerprint": "483ae8c038244eb3ed709e89846335e2c8ff6579260348ec31d3d03d1c94ad64",
|
|
"check_name": "CrossSiteScripting",
|
|
"message": "Unescaped model attribute",
|
|
"file": "app/views/users/dossiers/merci.html.haml",
|
|
"line": 28,
|
|
"link": "https://brakemanscanner.org/docs/warning_types/cross_site_scripting",
|
|
"code": "current_user.dossiers.includes(:procedure).find(params[:id]).procedure.monavis_embed",
|
|
"render_path": [
|
|
{
|
|
"type": "controller",
|
|
"class": "Users::DossiersController",
|
|
"method": "merci",
|
|
"line": 195,
|
|
"file": "app/controllers/users/dossiers_controller.rb",
|
|
"rendered": {
|
|
"name": "users/dossiers/merci",
|
|
"file": "app/views/users/dossiers/merci.html.haml"
|
|
}
|
|
}
|
|
],
|
|
"location": {
|
|
"type": "template",
|
|
"template": "users/dossiers/merci"
|
|
},
|
|
"user_input": "current_user.dossiers.includes(:procedure)",
|
|
"confidence": "Weak",
|
|
"note": ""
|
|
},
|
|
{
|
|
"warning_type": "SQL Injection",
|
|
"warning_code": 0,
|
|
"fingerprint": "6c98e520dd368104bb0c81334875010711cd523afc28057ef86a10930f95c4b7",
|
|
"check_name": "SQL",
|
|
"message": "Possible SQL injection",
|
|
"file": "app/models/stat.rb",
|
|
"line": 83,
|
|
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
|
|
"code": "association.where(date_attribute => ((3.months.ago.beginning_of_month.to_date..max_date))).group(\"DATE_TRUNC('month', #{date_attribute})\")",
|
|
"render_path": null,
|
|
"location": {
|
|
"type": "method",
|
|
"class": "Stat",
|
|
"method": "last_four_months_hash"
|
|
},
|
|
"user_input": "date_attribute",
|
|
"confidence": "Weak",
|
|
"note": "no user input, fixed value"
|
|
},
|
|
{
|
|
"warning_type": "SQL Injection",
|
|
"warning_code": 0,
|
|
"fingerprint": "bd1df30f95135357b646e21a03d95498874faffa32e3804fc643e9b6b957ee14",
|
|
"check_name": "SQL",
|
|
"message": "Possible SQL injection",
|
|
"file": "app/models/concerns/dossier_filtering_concern.rb",
|
|
"line": 18,
|
|
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
|
|
"code": "where(\"#{values.count} OR #{\"(#{ProcedurePresentation.sanitized_column(table, column)} ILIKE ?)\"}\", *values.map do\n \"%#{value}%\"\n end)",
|
|
"render_path": null,
|
|
"location": {
|
|
"type": "method",
|
|
"class": "DossierFilteringConcern",
|
|
"method": null
|
|
},
|
|
"user_input": "values.count",
|
|
"confidence": "Medium",
|
|
"note": "The table and column are escaped, which should make this safe"
|
|
},
|
|
{
|
|
"warning_type": "Redirect",
|
|
"warning_code": 18,
|
|
"fingerprint": "c46b5c9cd6474ffae789f39a2280ba6b5a5a74d3ffa8a38cf8a409f9a027ed0e",
|
|
"check_name": "Redirect",
|
|
"message": "Possible unprotected redirect",
|
|
"file": "app/controllers/instructeurs/procedures_controller.rb",
|
|
"line": 190,
|
|
"link": "https://brakemanscanner.org/docs/warning_types/redirect/",
|
|
"code": "redirect_to(Export.find_or_create_export(params[:export_format], (params[:time_span_type] or \"everything\"), current_instructeur.groupe_instructeurs.where(:procedure => procedure)).file.service_url)",
|
|
"render_path": null,
|
|
"location": {
|
|
"type": "method",
|
|
"class": "Instructeurs::ProceduresController",
|
|
"method": "download_export"
|
|
},
|
|
"user_input": "Export.find_or_create_export(params[:export_format], (params[:time_span_type] or \"everything\"), current_instructeur.groupe_instructeurs.where(:procedure => procedure)).file.service_url",
|
|
"confidence": "High",
|
|
"note": ""
|
|
},
|
|
{
|
|
"warning_type": "SQL Injection",
|
|
"warning_code": 0,
|
|
"fingerprint": "dc6d873aff3dc5e51e3349b17e1f35039b23d0bddbf04224b0f1bca3e4608c1e",
|
|
"check_name": "SQL",
|
|
"message": "Possible SQL injection",
|
|
"file": "app/models/stat.rb",
|
|
"line": 97,
|
|
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
|
|
"code": "association.where(\"#{date_attribute} < ?\", max_date).group(\"DATE_TRUNC('month', #{date_attribute})\")",
|
|
"render_path": null,
|
|
"location": {
|
|
"type": "method",
|
|
"class": "Stat",
|
|
"method": "cumulative_hash"
|
|
},
|
|
"user_input": "date_attribute",
|
|
"confidence": "Weak",
|
|
"note": "no user input, fixed value"
|
|
}
|
|
],
|
|
"updated": "2021-11-26 13:22:41 +0100",
|
|
"brakeman_version": "5.1.1"
|
|
}
|