492 lines
21 KiB
Ruby
492 lines
21 KiB
Ruby
describe Instructeurs::ProceduresController, type: :controller do
|
||
describe "before_action: ensure_ownership!" do
|
||
it "is present" do
|
||
before_actions = Instructeurs::ProceduresController
|
||
._process_action_callbacks
|
||
.filter { |process_action_callbacks| process_action_callbacks.kind == :before }
|
||
.map(&:filter)
|
||
|
||
expect(before_actions).to include(:ensure_ownership!)
|
||
end
|
||
end
|
||
|
||
describe "ensure_ownership!" do
|
||
let(:instructeur) { create(:instructeur) }
|
||
|
||
before do
|
||
@controller.params = @controller.params.merge(procedure_id: asked_procedure.id)
|
||
expect(@controller).to receive(:current_instructeur).and_return(instructeur)
|
||
allow(@controller).to receive(:redirect_to)
|
||
|
||
@controller.send(:ensure_ownership!)
|
||
end
|
||
|
||
context "when a instructeur asks for its procedure" do
|
||
let(:asked_procedure) { create(:procedure, instructeurs: [instructeur]) }
|
||
|
||
it "does not redirects nor flash" do
|
||
expect(@controller).not_to have_received(:redirect_to)
|
||
expect(flash.alert).to eq(nil)
|
||
end
|
||
end
|
||
|
||
context "when a instructeur asks for another procedure" do
|
||
let(:asked_procedure) { create(:procedure) }
|
||
|
||
it "redirects and flash" do
|
||
expect(@controller).to have_received(:redirect_to).with(root_path)
|
||
expect(flash.alert).to eq("Vous n’avez pas accès à cette démarche")
|
||
end
|
||
end
|
||
end
|
||
|
||
describe "#index" do
|
||
let(:instructeur) { create(:instructeur) }
|
||
subject { get :index }
|
||
|
||
context "when not logged" do
|
||
before { subject }
|
||
it { expect(response).to redirect_to(new_user_session_path) }
|
||
end
|
||
|
||
context "when logged in" do
|
||
before { sign_in(instructeur.user) }
|
||
|
||
it { expect(response).to have_http_status(:ok) }
|
||
|
||
context "with procedures assigned" do
|
||
let(:procedure_draft) { create(:procedure) }
|
||
let(:procedure_published) { create(:procedure, :published) }
|
||
let(:procedure_closed) { create(:procedure, :closed) }
|
||
let(:procedure_draft_discarded) { create(:procedure, :discarded) }
|
||
let(:procedure_closed_discarded) { create(:procedure, :discarded) }
|
||
let(:procedure_not_assigned) { create(:procedure) }
|
||
|
||
before do
|
||
[procedure_draft, procedure_published, procedure_closed, procedure_draft_discarded, procedure_closed_discarded].each do |p|
|
||
instructeur.groupe_instructeurs << p.defaut_groupe_instructeur
|
||
end
|
||
subject
|
||
end
|
||
|
||
it 'assigns procedures visible to the instructeur' do
|
||
expect(assigns(:procedures)).to include(procedure_draft, procedure_published, procedure_closed)
|
||
expect(assigns(:procedures)).not_to include(procedure_draft_discarded, procedure_closed_discarded, procedure_not_assigned)
|
||
end
|
||
end
|
||
|
||
context "with dossiers" do
|
||
let(:procedure) { create(:procedure, :published) }
|
||
let(:dossier) { create(:dossier, state: state, procedure: procedure) }
|
||
|
||
before do
|
||
instructeur.groupe_instructeurs << procedure.defaut_groupe_instructeur
|
||
dossier
|
||
end
|
||
|
||
context "with brouillon state" do
|
||
let(:state) { Dossier.states.fetch(:brouillon) }
|
||
before { subject }
|
||
|
||
it { expect(assigns(:dossiers_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
it { expect(assigns(:dossiers_a_suivre_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
it { expect(assigns(:dossiers_archived_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
it { expect(assigns(:followed_dossiers_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
it { expect(assigns(:dossiers_termines_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
|
||
it { expect(assigns(:all_dossiers_counts)['à suivre']).to eq(0) }
|
||
it { expect(assigns(:all_dossiers_counts)['suivis']).to eq(0) }
|
||
it { expect(assigns(:all_dossiers_counts)['traités']).to eq(0) }
|
||
it { expect(assigns(:all_dossiers_counts)['dossiers']).to eq(0) }
|
||
it { expect(assigns(:all_dossiers_counts)['archivés']).to eq(0) }
|
||
end
|
||
|
||
context "with not draft state on multiple procedures" do
|
||
let(:procedure2) { create(:procedure, :published) }
|
||
let(:state) { Dossier.states.fetch(:en_construction) }
|
||
|
||
before do
|
||
create(:dossier, procedure: procedure, state: Dossier.states.fetch(:en_construction))
|
||
create(:dossier, procedure: procedure, state: Dossier.states.fetch(:en_instruction))
|
||
create(:dossier, procedure: procedure, state: Dossier.states.fetch(:sans_suite), archived: true)
|
||
|
||
instructeur.groupe_instructeurs << procedure2.defaut_groupe_instructeur
|
||
create(:dossier, :followed, procedure: procedure2, state: Dossier.states.fetch(:en_construction))
|
||
create(:dossier, procedure: procedure2, state: Dossier.states.fetch(:accepte))
|
||
instructeur.followed_dossiers << create(:dossier, procedure: procedure2, state: Dossier.states.fetch(:en_instruction))
|
||
|
||
subject
|
||
end
|
||
|
||
it { expect(assigns(:dossiers_count_per_procedure)[procedure.id]).to eq(3) }
|
||
it { expect(assigns(:dossiers_a_suivre_count_per_procedure)[procedure.id]).to eq(3) }
|
||
it { expect(assigns(:followed_dossiers_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
it { expect(assigns(:dossiers_archived_count_per_procedure)[procedure.id]).to eq(1) }
|
||
it { expect(assigns(:dossiers_termines_count_per_procedure)[procedure.id]).to eq(nil) }
|
||
|
||
it { expect(assigns(:dossiers_count_per_procedure)[procedure2.id]).to eq(3) }
|
||
it { expect(assigns(:dossiers_a_suivre_count_per_procedure)[procedure2.id]).to eq(nil) }
|
||
it { expect(assigns(:followed_dossiers_count_per_procedure)[procedure2.id]).to eq(1) }
|
||
it { expect(assigns(:dossiers_archived_count_per_procedure)[procedure2.id]).to eq(nil) }
|
||
it { expect(assigns(:dossiers_termines_count_per_procedure)[procedure2.id]).to eq(1) }
|
||
|
||
it { expect(assigns(:all_dossiers_counts)['à suivre']).to eq(3 + 0) }
|
||
it { expect(assigns(:all_dossiers_counts)['suivis']).to eq(0 + 1) }
|
||
it { expect(assigns(:all_dossiers_counts)['traités']).to eq(0 + 1) }
|
||
it { expect(assigns(:all_dossiers_counts)['dossiers']).to eq(3 + 3) }
|
||
it { expect(assigns(:all_dossiers_counts)['archivés']).to eq(1 + 0) }
|
||
end
|
||
end
|
||
|
||
context "with a routed procedure" do
|
||
let!(:procedure) { create(:procedure, :published) }
|
||
let!(:gi_p1_1) { procedure.defaut_groupe_instructeur }
|
||
let!(:gi_p1_2) { GroupeInstructeur.create(label: '2', procedure: procedure) }
|
||
|
||
context 'with multiple dossiers en construction on each group' do
|
||
before do
|
||
alternate_gis = 0.upto(20).map { |i| i.even? ? gi_p1_1 : gi_p1_2 }
|
||
|
||
alternate_gis.take(4).each { |gi| create(:dossier, procedure: procedure, state: Dossier.states.fetch(:en_construction), groupe_instructeur: gi) }
|
||
|
||
alternate_gis.take(6).each do |gi|
|
||
instructeur.followed_dossiers << create(:dossier, procedure: procedure, state: Dossier.states.fetch(:en_instruction), groupe_instructeur: gi)
|
||
end
|
||
|
||
alternate_gis.take(10).each { |gi| create(:dossier, procedure: procedure, state: Dossier.states.fetch(:sans_suite), groupe_instructeur: gi) }
|
||
alternate_gis.take(14).each { |gi| create(:dossier, procedure: procedure, state: Dossier.states.fetch(:sans_suite), archived: true, groupe_instructeur: gi) }
|
||
end
|
||
|
||
context 'when an instructeur belongs to the 2 gi' do
|
||
before do
|
||
instructeur.groupe_instructeurs << gi_p1_1 << gi_p1_2
|
||
|
||
subject
|
||
end
|
||
|
||
it { expect(assigns(:dossiers_a_suivre_count_per_procedure)[procedure.id]).to eq(4) }
|
||
it { expect(assigns(:followed_dossiers_count_per_procedure)[procedure.id]).to eq(6) }
|
||
it { expect(assigns(:dossiers_termines_count_per_procedure)[procedure.id]).to eq(10) }
|
||
it { expect(assigns(:dossiers_count_per_procedure)[procedure.id]).to eq(4 + 6 + 10) }
|
||
it { expect(assigns(:dossiers_archived_count_per_procedure)[procedure.id]).to eq(14) }
|
||
|
||
it { expect(assigns(:all_dossiers_counts)['à suivre']).to eq(4) }
|
||
it { expect(assigns(:all_dossiers_counts)['suivis']).to eq(6) }
|
||
it { expect(assigns(:all_dossiers_counts)['traités']).to eq(10) }
|
||
it { expect(assigns(:all_dossiers_counts)['dossiers']).to eq(4 + 6 + 10) }
|
||
it { expect(assigns(:all_dossiers_counts)['archivés']).to eq(14) }
|
||
end
|
||
|
||
context 'when an instructeur only belongs to one of them gi' do
|
||
before do
|
||
instructeur.groupe_instructeurs << gi_p1_1
|
||
|
||
subject
|
||
end
|
||
|
||
it { expect(assigns(:dossiers_a_suivre_count_per_procedure)[procedure.id]).to eq(2) }
|
||
# An instructeur cannot follow a dossier which belongs to another groupe
|
||
it { expect(assigns(:followed_dossiers_count_per_procedure)[procedure.id]).to eq(3) }
|
||
it { expect(assigns(:dossiers_termines_count_per_procedure)[procedure.id]).to eq(5) }
|
||
it { expect(assigns(:dossiers_count_per_procedure)[procedure.id]).to eq(2 + 3 + 5) }
|
||
it { expect(assigns(:dossiers_archived_count_per_procedure)[procedure.id]).to eq(7) }
|
||
|
||
it { expect(assigns(:all_dossiers_counts)['à suivre']).to eq(2) }
|
||
it { expect(assigns(:all_dossiers_counts)['suivis']).to eq(3) }
|
||
it { expect(assigns(:all_dossiers_counts)['traités']).to eq(5) }
|
||
it { expect(assigns(:all_dossiers_counts)['dossiers']).to eq(2 + 3 + 5) }
|
||
it { expect(assigns(:all_dossiers_counts)['archivés']).to eq(7) }
|
||
end
|
||
end
|
||
end
|
||
end
|
||
end
|
||
|
||
describe "#show" do
|
||
let(:instructeur) { create(:instructeur) }
|
||
let!(:procedure) { create(:procedure, instructeurs: [instructeur]) }
|
||
let!(:gi_2) { procedure.groupe_instructeurs.create(label: '2') }
|
||
let!(:gi_3) { procedure.groupe_instructeurs.create(label: '3') }
|
||
let(:statut) { nil }
|
||
|
||
subject do
|
||
get :show, params: { procedure_id: procedure.id, statut: statut }
|
||
end
|
||
|
||
context "when logged in, and belonging to gi_1, gi_2" do
|
||
before do
|
||
sign_in(instructeur.user)
|
||
instructeur.groupe_instructeurs << gi_2
|
||
end
|
||
|
||
context 'when the procedure is discarded' do
|
||
before do
|
||
procedure.discard!
|
||
end
|
||
|
||
it { expect { subject }.to raise_error(ActiveRecord::RecordNotFound) }
|
||
end
|
||
|
||
context "without any dossier" do
|
||
before { subject }
|
||
|
||
it { expect(response).to have_http_status(:ok) }
|
||
it { expect(assigns(:procedure)).to eq(procedure) }
|
||
end
|
||
|
||
context 'with a new dossier without follower' do
|
||
let!(:new_unfollow_dossier) { create(:dossier, :en_instruction, procedure: procedure) }
|
||
|
||
before { subject }
|
||
|
||
it { expect(assigns(:a_suivre_dossiers)).to match_array([new_unfollow_dossier]) }
|
||
it { expect(assigns(:followed_dossiers)).to be_empty }
|
||
it { expect(assigns(:termines_dossiers)).to be_empty }
|
||
it { expect(assigns(:all_state_dossiers)).to match_array([new_unfollow_dossier]) }
|
||
it { expect(assigns(:archived_dossiers)).to be_empty }
|
||
|
||
context 'and dossiers without follower on each of the others groups' do
|
||
let!(:new_unfollow_dossier_on_gi_2) { create(:dossier, groupe_instructeur: gi_2, state: Dossier.states.fetch(:en_instruction)) }
|
||
let!(:new_unfollow_dossier_on_gi_3) { create(:dossier, groupe_instructeur: gi_3, state: Dossier.states.fetch(:en_instruction)) }
|
||
|
||
before { subject }
|
||
|
||
it { expect(assigns(:a_suivre_dossiers)).to match_array([new_unfollow_dossier, new_unfollow_dossier_on_gi_2]) }
|
||
it { expect(assigns(:all_state_dossiers)).to match_array([new_unfollow_dossier, new_unfollow_dossier_on_gi_2]) }
|
||
end
|
||
end
|
||
|
||
context 'with a new dossier with a follower' do
|
||
let!(:new_followed_dossier) { create(:dossier, :en_instruction, procedure: procedure) }
|
||
|
||
before do
|
||
instructeur.followed_dossiers << new_followed_dossier
|
||
subject
|
||
end
|
||
|
||
it { expect(assigns(:a_suivre_dossiers)).to be_empty }
|
||
it { expect(assigns(:followed_dossiers)).to match_array([new_followed_dossier]) }
|
||
it { expect(assigns(:termines_dossiers)).to be_empty }
|
||
it { expect(assigns(:all_state_dossiers)).to match_array([new_followed_dossier]) }
|
||
it { expect(assigns(:archived_dossiers)).to be_empty }
|
||
|
||
context 'and dossier with a follower on each of the others groups' do
|
||
let!(:new_follow_dossier_on_gi_2) { create(:dossier, groupe_instructeur: gi_2, state: Dossier.states.fetch(:en_instruction)) }
|
||
let!(:new_follow_dossier_on_gi_3) { create(:dossier, groupe_instructeur: gi_3, state: Dossier.states.fetch(:en_instruction)) }
|
||
|
||
before do
|
||
instructeur.followed_dossiers << new_follow_dossier_on_gi_2 << new_follow_dossier_on_gi_3
|
||
subject
|
||
end
|
||
|
||
# followed dossiers on another groupe should not be displayed
|
||
it { expect(assigns(:followed_dossiers)).to contain_exactly(new_followed_dossier, new_follow_dossier_on_gi_2) }
|
||
it { expect(assigns(:all_state_dossiers)).to contain_exactly(new_followed_dossier, new_follow_dossier_on_gi_2) }
|
||
end
|
||
end
|
||
|
||
context 'with a termine dossier with a follower' do
|
||
let!(:termine_dossier) { create(:dossier, :accepte, procedure: procedure) }
|
||
|
||
before { subject }
|
||
|
||
it { expect(assigns(:a_suivre_dossiers)).to be_empty }
|
||
it { expect(assigns(:followed_dossiers)).to be_empty }
|
||
it { expect(assigns(:termines_dossiers)).to match_array([termine_dossier]) }
|
||
it { expect(assigns(:all_state_dossiers)).to match_array([termine_dossier]) }
|
||
it { expect(assigns(:archived_dossiers)).to be_empty }
|
||
|
||
context 'and terminer dossiers on each of the others groups' do
|
||
let!(:termine_dossier_on_gi_2) { create(:dossier, groupe_instructeur: gi_2, state: Dossier.states.fetch(:accepte)) }
|
||
let!(:termine_dossier_on_gi_3) { create(:dossier, groupe_instructeur: gi_3, state: Dossier.states.fetch(:accepte)) }
|
||
|
||
before { subject }
|
||
|
||
it { expect(assigns(:termines_dossiers)).to match_array([termine_dossier, termine_dossier_on_gi_2]) }
|
||
it { expect(assigns(:all_state_dossiers)).to match_array([termine_dossier, termine_dossier_on_gi_2]) }
|
||
end
|
||
end
|
||
|
||
context 'with an archived dossier' do
|
||
let!(:archived_dossier) { create(:dossier, :en_instruction, procedure: procedure, archived: true) }
|
||
|
||
before { subject }
|
||
|
||
it { expect(assigns(:a_suivre_dossiers)).to be_empty }
|
||
it { expect(assigns(:followed_dossiers)).to be_empty }
|
||
it { expect(assigns(:termines_dossiers)).to be_empty }
|
||
it { expect(assigns(:all_state_dossiers)).to be_empty }
|
||
it { expect(assigns(:archived_dossiers)).to match_array([archived_dossier]) }
|
||
|
||
context 'and terminer dossiers on each of the others groups' do
|
||
let!(:archived_dossier_on_gi_2) { create(:dossier, :en_instruction, groupe_instructeur: gi_2, archived: true) }
|
||
let!(:archived_dossier_on_gi_3) { create(:dossier, :en_instruction, groupe_instructeur: gi_3, archived: true) }
|
||
|
||
before { subject }
|
||
|
||
it { expect(assigns(:archived_dossiers)).to match_array([archived_dossier, archived_dossier_on_gi_2]) }
|
||
end
|
||
end
|
||
|
||
describe 'statut' do
|
||
let!(:a_suivre__dossier) { Timecop.freeze(1.day.ago) { create(:dossier, :en_instruction, procedure: procedure) } }
|
||
let!(:new_followed_dossier) { Timecop.freeze(2.days.ago) { create(:dossier, :en_instruction, procedure: procedure) } }
|
||
let!(:termine_dossier) { Timecop.freeze(3.days.ago) { create(:dossier, :accepte, procedure: procedure) } }
|
||
let!(:archived_dossier) { Timecop.freeze(4.days.ago) { create(:dossier, :en_instruction, procedure: procedure, archived: true) } }
|
||
|
||
before do
|
||
instructeur.followed_dossiers << new_followed_dossier
|
||
subject
|
||
end
|
||
|
||
context 'when statut is empty' do
|
||
let(:statut) { nil }
|
||
|
||
it { expect(assigns(:dossiers)).to match_array([a_suivre__dossier]) }
|
||
it { expect(assigns(:statut)).to eq('a-suivre') }
|
||
end
|
||
|
||
context 'when statut is a-suivre' do
|
||
let(:statut) { 'a-suivre' }
|
||
|
||
it { expect(assigns(:statut)).to eq('a-suivre') }
|
||
it { expect(assigns(:dossiers)).to match_array([a_suivre__dossier]) }
|
||
end
|
||
|
||
context 'when statut is suivis' do
|
||
let(:statut) { 'suivis' }
|
||
|
||
it { expect(assigns(:statut)).to eq('suivis') }
|
||
it { expect(assigns(:dossiers)).to match_array([new_followed_dossier]) }
|
||
end
|
||
|
||
context 'when statut is traites' do
|
||
let(:statut) { 'traites' }
|
||
|
||
it { expect(assigns(:statut)).to eq('traites') }
|
||
it { expect(assigns(:dossiers)).to match_array([termine_dossier]) }
|
||
end
|
||
|
||
context 'when statut is tous' do
|
||
let(:statut) { 'tous' }
|
||
|
||
it { expect(assigns(:statut)).to eq('tous') }
|
||
it { expect(assigns(:dossiers)).to match_array([a_suivre__dossier, new_followed_dossier, termine_dossier]) }
|
||
end
|
||
|
||
context 'when statut is archives' do
|
||
let(:statut) { 'archives' }
|
||
|
||
it { expect(assigns(:statut)).to eq('archives') }
|
||
it { expect(assigns(:dossiers)).to match_array([archived_dossier]) }
|
||
end
|
||
end
|
||
end
|
||
end
|
||
|
||
describe '#deleted_dossiers' do
|
||
let(:instructeur) { create(:instructeur) }
|
||
let(:procedure) { create(:procedure, instructeurs: [instructeur]) }
|
||
let(:deleted_dossier) { create(:deleted_dossier, procedure: procedure, state: :en_construction) }
|
||
|
||
before do
|
||
sign_in(instructeur.user)
|
||
get :deleted_dossiers, params: { procedure_id: procedure.id }
|
||
end
|
||
|
||
it { expect(assigns(:deleted_dossiers)).to match_array([deleted_dossier]) }
|
||
end
|
||
|
||
describe '#update_email_notifications' do
|
||
let(:instructeur) { create(:instructeur) }
|
||
let!(:procedure) { create(:procedure, instructeurs: [instructeur]) }
|
||
|
||
context "when logged in" do
|
||
before { sign_in(instructeur.user) }
|
||
|
||
it { expect(instructeur.groupe_instructeur_with_email_notifications).to be_empty }
|
||
|
||
context 'when the instructeur update its preferences' do
|
||
let(:assign_to) { instructeur.assign_to.joins(:groupe_instructeur).find_by(groupe_instructeurs: { procedure: procedure }) }
|
||
|
||
before do
|
||
patch :update_email_notifications, params: { procedure_id: procedure.id, assign_to: { id: assign_to.id, daily_email_notifications_enabled: true } }
|
||
end
|
||
|
||
it { expect(instructeur.groupe_instructeur_with_email_notifications).to eq([procedure.defaut_groupe_instructeur]) }
|
||
end
|
||
end
|
||
end
|
||
|
||
describe '#download_export' do
|
||
let(:instructeur) { create(:instructeur) }
|
||
let!(:procedure) { create(:procedure) }
|
||
let!(:gi_0) { procedure.defaut_groupe_instructeur }
|
||
let!(:gi_1) { GroupeInstructeur.create(label: 'gi_1', procedure: procedure, instructeurs: [instructeur]) }
|
||
|
||
before { sign_in(instructeur.user) }
|
||
|
||
subject do
|
||
get :download_export, params: { export_format: :csv, procedure_id: procedure.id }
|
||
end
|
||
|
||
context 'when the export is does not exist' do
|
||
it 'displays an notice' do
|
||
is_expected.to redirect_to(instructeur_procedure_url(procedure))
|
||
expect(flash.notice).to be_present
|
||
end
|
||
|
||
it { expect { subject }.to change(Export, :count).by(1) }
|
||
end
|
||
|
||
context 'when the export is not ready' do
|
||
before do
|
||
create(:export, groupe_instructeurs: [gi_1])
|
||
end
|
||
|
||
it 'displays an notice' do
|
||
is_expected.to redirect_to(instructeur_procedure_url(procedure))
|
||
expect(flash.notice).to be_present
|
||
end
|
||
end
|
||
|
||
context 'when the export is ready' do
|
||
let!(:export) { create(:export, groupe_instructeurs: [gi_1]) }
|
||
|
||
before do
|
||
export.file.attach(io: StringIO.new('export'), filename: 'file.csv')
|
||
end
|
||
|
||
it 'displays the download link' do
|
||
subject
|
||
expect(response.headers['Location']).to start_with("http://test.host/rails/active_storage/disk")
|
||
end
|
||
end
|
||
|
||
context 'when another export is ready' do
|
||
let!(:export) { create(:export, groupe_instructeurs: [gi_0, gi_1]) }
|
||
|
||
before do
|
||
export.file.attach(io: StringIO.new('export'), filename: 'file.csv')
|
||
end
|
||
|
||
it 'displays an notice' do
|
||
is_expected.to redirect_to(instructeur_procedure_url(procedure))
|
||
expect(flash.notice).to be_present
|
||
end
|
||
end
|
||
|
||
context 'when the js format is used' do
|
||
before do
|
||
post :download_export,
|
||
params: { export_format: :csv, procedure_id: procedure.id },
|
||
format: :js
|
||
end
|
||
|
||
it 'responds in the correct format' do
|
||
expect(response.media_type).to eq('text/javascript')
|
||
expect(response).to have_http_status(:ok)
|
||
end
|
||
end
|
||
end
|
||
end
|