4cb747fdb6
Test helpers are separated between two files: spec_helper and rails_helper. This separation is meant to allow tests that do not require Rails (like testing standalone libs) to boot faster. The spec_helper file is always loaded, through `--require spec_helper` in the `.rspec` config file. When needed, the rails_helper file is expected to be required manually. This is fine, but: - Many test files have a redundant `require 'spec_helper'` line; - Many test files should require `rails_helper`, but don't. Not requiring `rails_helper` will cause the Rails-concerned section of the test environment not to be configured–which may cause subtle bugs (like the test database not being properly initialized). Moreover, Spring loads all the Rails files on preloading anyway. So the gains from using only `spec_helper` are thin. To streamline this process, this commit: - Configures `.rspec` to require `rails_helper` by default; - Remove all manual requires to spec_helper or rails_helper. Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
61 lines
1.4 KiB
Ruby
61 lines
1.4 KiB
Ruby
describe IPService do
|
|
describe '.ip_trusted?' do
|
|
after(:each) { ENV['TRUSTED_NETWORKS'] = nil }
|
|
|
|
subject { IPService.ip_trusted?(ip) }
|
|
|
|
context 'when the ip is nil' do
|
|
let(:ip) { nil }
|
|
|
|
it { is_expected.to be(false) }
|
|
end
|
|
|
|
context 'when the ip is defined' do
|
|
let(:ip) { '192.168.1.10' }
|
|
|
|
context 'when it belongs to a trusted network' do
|
|
before do
|
|
ENV['TRUSTED_NETWORKS'] = '10.0.0.0/8 192.168.0.0/16 bad_network'
|
|
end
|
|
|
|
it { is_expected.to be(true) }
|
|
end
|
|
|
|
context 'when it does not belong to a trusted network' do
|
|
before do
|
|
ENV['TRUSTED_NETWORKS'] = '10.0.0.0/8'
|
|
end
|
|
|
|
it { is_expected.to be(false) }
|
|
end
|
|
|
|
context 'when the trusted network is not defined' do
|
|
it { is_expected.to be(false) }
|
|
end
|
|
|
|
context 'when the trusted network is malformed' do
|
|
before do
|
|
ENV['TRUSTED_NETWORKS'] = 'bad network'
|
|
end
|
|
|
|
it { is_expected.to be(false) }
|
|
end
|
|
end
|
|
|
|
context 'when a trusted network is defined' do
|
|
before { ENV['TRUSTED_NETWORKS'] = '10.0.0.0/8' }
|
|
|
|
context 'when the ip is nil' do
|
|
let(:ip) { nil }
|
|
|
|
it { is_expected.to be(false) }
|
|
end
|
|
|
|
context 'when the ip is badly formatted' do
|
|
let(:ip) { 'yop' }
|
|
|
|
it { is_expected.to be(false) }
|
|
end
|
|
end
|
|
end
|
|
end
|