75a1046315
Follow-up of #5953. Refactor the concerns with two goals: - Getting closer from the way ActiveStorage adds its own hooks. Usually ActiveStorage does this using an `Attachment#after_create` hook, which then delegates to the blob to enqueue the job. - Enqueuing each job only once. By hooking on `Attachment#after_create`, we guarantee each job will be added only once. We then let the jobs themselves check if they are relevant or not, and retry or discard themselves if necessary. We also need to update the tests a bit, because Rails' `perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on` clause of jobs. Instead it forwards the exception to the caller – which makes the test fail. Instead we use the inline version of `perform_enqueued_jobs()`, without a block, which properly ignores errors catched by retry_on.
20 lines
599 B
Ruby
20 lines
599 B
Ruby
# Run a virus scan on all attachments after they are analyzed.
|
|
#
|
|
# We're using a class extension to ensure that all attachments get scanned,
|
|
# regardless on how they were created. This could be an ActiveStorage::Analyzer,
|
|
# but as of Rails 6.1 only the first matching analyzer is ever run on
|
|
# a blob (and we may want to analyze the dimension of a picture as well
|
|
# as scanning it).
|
|
module AttachmentVirusScannerConcern
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
after_create_commit :scan_for_virus_later
|
|
end
|
|
|
|
private
|
|
|
|
def scan_for_virus_later
|
|
blob&.scan_for_virus_later
|
|
end
|
|
end
|