4cb747fdb6
Test helpers are separated between two files: spec_helper and rails_helper. This separation is meant to allow tests that do not require Rails (like testing standalone libs) to boot faster. The spec_helper file is always loaded, through `--require spec_helper` in the `.rspec` config file. When needed, the rails_helper file is expected to be required manually. This is fine, but: - Many test files have a redundant `require 'spec_helper'` line; - Many test files should require `rails_helper`, but don't. Not requiring `rails_helper` will cause the Rails-concerned section of the test environment not to be configured–which may cause subtle bugs (like the test database not being properly initialized). Moreover, Spring loads all the Rails files on preloading anyway. So the gains from using only `spec_helper` are thin. To streamline this process, this commit: - Configures `.rspec` to require `rails_helper` by default; - Remove all manual requires to spec_helper or rails_helper. Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
161 lines
5 KiB
Ruby
161 lines
5 KiB
Ruby
describe Users::CommencerController, type: :controller do
|
||
let(:user) { create(:user) }
|
||
let(:published_procedure) { create(:procedure, :published) }
|
||
let(:draft_procedure) { create(:procedure, :with_path) }
|
||
|
||
describe '#commencer' do
|
||
subject { get :commencer, params: { path: path } }
|
||
|
||
context 'when the path is for a published procedure' do
|
||
let(:path) { published_procedure.path }
|
||
|
||
it 'renders the view' do
|
||
expect(subject.status).to eq(200)
|
||
expect(subject).to render_template('show')
|
||
expect(assigns(:procedure)).to eq published_procedure
|
||
end
|
||
end
|
||
|
||
context 'when the path is for a draft procedure' do
|
||
let(:path) { draft_procedure.path }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
|
||
context 'when the path does not exist' do
|
||
let(:path) { 'hello' }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
end
|
||
|
||
describe '#commencer_test' do
|
||
subject { get :commencer_test, params: { path: path } }
|
||
|
||
context 'when the path is for a draft procedure' do
|
||
let(:path) { draft_procedure.path }
|
||
|
||
it 'renders the view' do
|
||
expect(subject.status).to eq(200)
|
||
expect(subject).to render_template('show')
|
||
expect(assigns(:procedure)).to eq draft_procedure
|
||
end
|
||
end
|
||
|
||
context 'when the path is for a published procedure' do
|
||
let(:path) { published_procedure.path }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
|
||
context 'when the path does not exist' do
|
||
let(:path) { 'hello' }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
end
|
||
|
||
describe '#sign_in' do
|
||
context 'for a published procedure' do
|
||
subject { get :sign_in, params: { path: published_procedure.path } }
|
||
|
||
it 'set the path to return after sign-in to the procedure start page' do
|
||
subject
|
||
expect(controller.stored_location_for(:user)).to eq(commencer_path(path: published_procedure.path))
|
||
end
|
||
|
||
it { expect(subject).to redirect_to(new_user_session_path) }
|
||
end
|
||
|
||
context 'for a draft procedure' do
|
||
subject { get :sign_in, params: { path: draft_procedure.path } }
|
||
|
||
it 'set the path to return after sign-in to the draft procedure start page' do
|
||
subject
|
||
expect(controller.stored_location_for(:user)).to eq(commencer_test_path(path: draft_procedure.path))
|
||
end
|
||
|
||
it { expect(subject).to redirect_to(new_user_session_path) }
|
||
end
|
||
|
||
context 'when the path doesn’t exist' do
|
||
subject { get :sign_in, params: { path: 'hello' } }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
end
|
||
|
||
describe '#sign_up' do
|
||
context 'for a published procedure' do
|
||
subject { get :sign_up, params: { path: published_procedure.path } }
|
||
|
||
it 'set the path to return after sign-up to the procedure start page' do
|
||
subject
|
||
expect(controller.stored_location_for(:user)).to eq(commencer_path(path: published_procedure.path))
|
||
end
|
||
|
||
it { expect(subject).to redirect_to(new_user_registration_path) }
|
||
end
|
||
|
||
context 'for a draft procedure' do
|
||
subject { get :sign_up, params: { path: draft_procedure.path } }
|
||
|
||
it 'set the path to return after sign-up to the draft procedure start page' do
|
||
subject
|
||
expect(controller.stored_location_for(:user)).to eq(commencer_test_path(path: draft_procedure.path))
|
||
end
|
||
|
||
it { expect(subject).to redirect_to(new_user_registration_path) }
|
||
end
|
||
|
||
context 'when the path doesn’t exist' do
|
||
subject { get :sign_up, params: { path: 'hello' } }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
end
|
||
|
||
describe '#france_connect' do
|
||
context 'for a published procedure' do
|
||
subject { get :france_connect, params: { path: published_procedure.path } }
|
||
|
||
it 'set the path to return after sign-up to the procedure start page' do
|
||
subject
|
||
expect(controller.stored_location_for(:user)).to eq(commencer_path(path: published_procedure.path))
|
||
end
|
||
|
||
it { expect(subject).to redirect_to(france_connect_particulier_path) }
|
||
end
|
||
|
||
context 'for a draft procedure' do
|
||
subject { get :france_connect, params: { path: draft_procedure.path } }
|
||
|
||
it 'set the path to return after sign-up to the draft procedure start page' do
|
||
subject
|
||
expect(controller.stored_location_for(:user)).to eq(commencer_test_path(path: draft_procedure.path))
|
||
end
|
||
|
||
it { expect(subject).to redirect_to(france_connect_particulier_path) }
|
||
end
|
||
|
||
context 'when the path doesn’t exist' do
|
||
subject { get :france_connect, params: { path: 'hello' } }
|
||
|
||
it 'redirects with an error message' do
|
||
expect(subject).to redirect_to(root_path)
|
||
end
|
||
end
|
||
end
|
||
end
|