demarches-normaliennes/spec/features/help_spec.rb
Pierre de La Morinerie 4cb747fdb6 specs: always require rails_helper
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00

100 lines
2.7 KiB
Ruby

feature 'Getting help:' do
scenario 'a Help button is visible on public pages' do
visit '/'
within('.new-header') do
expect(page).to have_help_button
end
end
context 'on pages related to a procedure' do
let(:procedure) { create(:procedure, :published, :with_service) }
scenario 'a Help menu provides administration contacts and a link to the FAQ' do
visit commencer_path(path: procedure.path)
within('.new-header') do
expect(page).to have_help_menu
end
within('.help-dropdown') do
expect(page).to have_content(procedure.service.email)
expect(page).to have_content(procedure.service.telephone)
expect(page).to have_link(nil, href: FAQ_URL)
end
end
end
context 'as a signed-in user' do
let(:user) { create(:user) }
let(:procedure) { create(:procedure, :with_service) }
before do
login_as user, scope: :user
end
scenario 'a Help button is visible on signed-in pages' do
visit dossiers_path
within('.new-header') do
expect(page).to have_help_button
end
end
context 'on a page related to a draft dossier' do
let(:dossier) { create(:dossier, user: user, procedure: procedure) }
scenario 'a Help menu provides administration contacts and a link to the FAQ' do
visit dossier_path(dossier)
within('.new-header') do
expect(page).to have_help_menu
end
within('.help-dropdown') do
expect(page).to have_content(dossier.procedure.service.email)
expect(page).to have_content(dossier.procedure.service.telephone)
expect(page).to have_link(nil, href: FAQ_URL)
end
end
end
context 'on a page related to a submitted dossier' do
let(:dossier) { create(:dossier, :en_construction, user: user, procedure: procedure) }
scenario 'a Help menu provides links to the Messagerie and to the FAQ' do
visit dossier_path(dossier)
within('.new-header') do
expect(page).to have_help_menu
end
within('.help-dropdown') do
expect(page).to have_link(nil, href: messagerie_dossier_path(dossier))
expect(page).to have_link(nil, href: FAQ_URL)
end
end
end
end
context 'as a instructeur' do
let(:instructeur) { create(:instructeur) }
before do
login_as instructeur.user, scope: :user
end
scenario 'a Help menu is visible on signed-in pages' do
visit instructeur_procedures_path
within('.new-header') do
expect(page).to have_help_menu
end
end
end
def have_help_button
have_link('Aide', href: FAQ_URL)
end
def have_help_menu
have_selector('.help-dropdown')
end
end