demarches-normaliennes/spec/models/groupe_instructeur_spec.rb
Pierre de La Morinerie 4cb747fdb6 specs: always require rails_helper
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00

36 lines
900 B
Ruby

describe GroupeInstructeur, type: :model do
let(:procedure) { create(:procedure) }
subject { GroupeInstructeur.new(label: label, procedure: procedure) }
context 'with no label provided' do
let(:label) { '' }
it { is_expected.to be_invalid }
end
context 'with a valid label' do
let(:label) { 'Préfecture de la Marne' }
it { is_expected.to be_valid }
end
context 'with a label with extra spaces' do
let(:label) { 'Préfecture de la Marne ' }
before do
subject.save
subject.reload
end
it { is_expected.to be_valid }
it { expect(subject.label).to eq("Préfecture de la Marne") }
end
context 'with a label already used for this procedure' do
let(:label) { 'Préfecture de la Marne' }
before do
GroupeInstructeur.create!(label: label, procedure: procedure)
end
it { is_expected.to be_invalid }
end
end