4cb747fdb6
Test helpers are separated between two files: spec_helper and rails_helper. This separation is meant to allow tests that do not require Rails (like testing standalone libs) to boot faster. The spec_helper file is always loaded, through `--require spec_helper` in the `.rspec` config file. When needed, the rails_helper file is expected to be required manually. This is fine, but: - Many test files have a redundant `require 'spec_helper'` line; - Many test files should require `rails_helper`, but don't. Not requiring `rails_helper` will cause the Rails-concerned section of the test environment not to be configured–which may cause subtle bugs (like the test database not being properly initialized). Moreover, Spring loads all the Rails files on preloading anyway. So the gains from using only `spec_helper` are thin. To streamline this process, this commit: - Configures `.rspec` to require `rails_helper` by default; - Remove all manual requires to spec_helper or rails_helper. Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
51 lines
1.6 KiB
Ruby
51 lines
1.6 KiB
Ruby
describe Helpscout::UserConversationsAdapter do
|
|
let(:from) { Date.new(2017, 11) }
|
|
let(:to) { Date.new(2017, 12) }
|
|
|
|
describe '#can_fetch_reports?' do
|
|
context 'when a required secret is missing' do
|
|
before do
|
|
Rails.application.secrets.helpscout[:mailbox_id] = nil
|
|
end
|
|
|
|
it { expect(described_class.new(from, to).can_fetch_reports?).to be false }
|
|
end
|
|
|
|
context 'when all required secrets are present' do
|
|
before do
|
|
mock_helpscout_secrets
|
|
end
|
|
|
|
it { expect(described_class.new(from, to).can_fetch_reports?).to be true }
|
|
end
|
|
end
|
|
|
|
describe '#reports', vcr: { cassette_name: 'helpscout_conversations_reports' } do
|
|
before do
|
|
mock_helpscout_secrets
|
|
Rails.cache.clear
|
|
end
|
|
|
|
subject { described_class.new(from, to) }
|
|
|
|
it 'returns one report result per month' do
|
|
expect(subject.reports.count).to eq 2
|
|
end
|
|
|
|
it 'populates each report with data' do
|
|
expect(subject.reports.first[:replies_sent]).to be > 0
|
|
expect(subject.reports.first[:start_date]).to eq Time.utc(2017, 11)
|
|
expect(subject.reports.first[:end_date]).to eq Time.utc(2017, 12)
|
|
|
|
expect(subject.reports.last[:replies_sent]).to be > 0
|
|
expect(subject.reports.last[:start_date]).to eq Time.utc(2017, 12)
|
|
expect(subject.reports.last[:end_date]).to eq Time.utc(2018, 01)
|
|
end
|
|
end
|
|
|
|
def mock_helpscout_secrets
|
|
Rails.application.secrets.helpscout[:mailbox_id] = '9999'
|
|
Rails.application.secrets.helpscout[:client_id] = '1234'
|
|
Rails.application.secrets.helpscout[:client_secret] = '5678'
|
|
end
|
|
end
|