Paul Chavard
8c5fd58bd1
Merge pull request #5099 from tchak/fix-draft-notofications
...
Do not send draft norifications to users on inactive démarches
2020-05-27 17:23:29 +02:00
Paul Chavard
20705d6e30
Do not send draft norifications to users on inactive démarches
2020-05-27 16:36:46 +02:00
krichtof
e3b6a33d89
Merge pull request #5191 from betagouv/bugfix-champ-siret
...
Fix. Ne met plus à jour l'établissement du dossier lors de la modif d'un champ siret
2020-05-26 18:26:32 +02:00
Christophe Robillard
fb87a09c02
doesn't update dossier etablissement for siret controller
2020-05-26 18:13:20 +02:00
Keirua
b8093962ec
Merge pull request #5185 from betagouv/aide-probleme-mail
...
Ajout de precisions pour les emails non reçus lors de la création de compte
2020-05-26 16:48:27 +02:00
clemkeirua
87f1e63e1b
ajout de precisions pour les emails non reçus
2020-05-26 15:46:51 +02:00
Keirua
08f21c3bd6
Merge pull request #5186 from betagouv/service-must-be-reachable
...
Précisions sur le caractère obligatoire des infos de service
2020-05-26 15:46:33 +02:00
Keirua
0727f99ac8
reformulation d'un libelle de l'editeur de services
...
Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>
2020-05-26 15:28:27 +02:00
clemkeirua
21ad7055a2
precisions sur le caractère obligatoire des infos de service
2020-05-25 15:47:02 +02:00
Pierre de La Morinerie
2b644eb042
Merge pull request #5183 from betagouv/fix-spring-pg-crash
...
Correction de crashes lors de l'utilisation de Spring
2020-05-25 11:45:39 +02:00
Pierre de La Morinerie
b0db74ea79
config: fix spring randomly crashing in the pg gem
...
See https://github.com/ged/ruby-pg/issues/311
2020-05-25 09:23:41 +00:00
Keirua
1adb197e96
Merge pull request #5184 from betagouv/remove-unused-spec
...
specs: remove unused test case
2020-05-25 09:10:30 +02:00
Pierre de La Morinerie
2f509c2536
specs: remove unused test case
...
Actual code was removed in 0ff6c793ae
The spec was never executed, because it lacked the `_spec.rb` suffix.
2020-05-20 17:45:06 +02:00
Keirua
af6731578a
Merge pull request #5182 from betagouv/5113-async-for-api-ent-calls
...
raise exception with url
2020-05-20 16:11:40 +02:00
Christophe Robillard
1b509c15f8
raise exception with url
2020-05-20 15:53:08 +02:00
Pierre de La Morinerie
8f283d1383
Merge pull request #5164 from betagouv/feat/5136
...
Usager : amélioration de l'interface d'import de données cartographiques
2020-05-20 14:28:31 +02:00
kara Diaby
d8ae089e93
[Carto] Improve files import UX + import KML files
2020-05-20 14:17:27 +02:00
krichtof
7c6d870925
Merge pull request #5176 from betagouv/5113-async-for-api-ent-calls
...
Passe la récupération des données API Entreprise en asynchrone
2020-05-20 11:22:12 +02:00
Christophe Robillard
8c66b2cab1
rescue ResourceNotFound and BadFormatRequest errors
...
we don't have to retry this kind of errors, but just to send it to
sentry
2020-05-20 11:09:54 +02:00
Christophe Robillard
d92a0ba8f3
raise BadFormatRequest error
...
L'intention est de distinguer ce type d'erreur avec les erreurs serveur
5xx.
Lorsque l'api est appelé par un Job, les erreurs serveur seront retry, car éphémères.
Alors que les erreurs de type BadFormatRequest ou ResourceNotFound n'ont
pas être retried.
2020-05-20 11:09:54 +02:00
Christophe Robillard
f40123fee1
display only etablissement infos
...
all the other infos are not yet available because the jobs which
retrieve it are performed later
2020-05-20 11:09:54 +02:00
Christophe Robillard
3b46594e60
precise http error code for api calls
2020-05-20 11:09:54 +02:00
Christophe Robillard
013e78ce4e
fix creating dossier feature sprec
2020-05-20 11:09:54 +02:00
Christophe Robillard
637bde7326
update siret_controller when finding etablissement
...
now, `ApiEntrepriseService` does'nt return a hash anymore but an
etablissement which is already persisted.
2020-05-20 11:09:54 +02:00
Christophe Robillard
eebfb5ee5b
update dossiers_controller when updating siret
...
now, `ApiEntrepriseService` does'nt return a hash anymore but an
etablissement which is already persisted.
2020-05-20 11:09:54 +02:00
Christophe Robillard
ba5fa9aa4b
update ApiEntrepriseService
...
There is now the `create_etablissement` method which
create etablissement with EtablissementAdapter
and enqueue api_entreprise jobs to retrieve
all informations we can get based on SIRET
2020-05-20 11:09:54 +02:00
Christophe Robillard
f4ebb5d107
create api_entreprise jobs
2020-05-20 11:09:54 +02:00
Christophe Robillard
e3ee423197
call api_entreprise adapters with siret
2020-05-20 11:09:54 +02:00
Pierre de La Morinerie
f7201dd17b
Merge pull request #5177 from betagouv/fix-search-input
2020-05-19 16:03:50 +02:00
kara Diaby
c37b32ac94
fix the search input addresses return box bug [Carto]
2020-05-19 15:34:48 +02:00
Pierre de La Morinerie
bf7c33949c
Merge pull request #5170 from betagouv/fix-faq-urls
...
Usager : correction du lien vers l'aide pour l'enregistrement automatique des brouillons
2020-05-18 16:53:50 +02:00
Pierre de La Morinerie
c9820adbc4
urls: fix link to autosave FAQ article
2020-05-18 16:53:19 +02:00
Pierre de La Morinerie
6eca93faab
urls: fix link to admin FAQ category
2020-05-18 16:53:19 +02:00
Keirua
6ccb09a9e3
Merge pull request #5171 from betagouv/fix-expired-dossiers-deletion
...
dossiers expiration: fix the mailer arguments
2020-05-18 16:39:57 +02:00
Pierre de La Morinerie
9f1407b6d7
expiration: fix the mailer arguments
...
The mailers expect serializable arguments, but were given
ActiveRecord::Relation objects instead. This made the mailers throw an
exception.
But how was that possible ? This code is tested, and the tests were
green.
Well, the specs spy on the mailer implementation, in order to check that
the mailers methods were properly called. Fair enough.
But if the specs mock the mailer code (instead of calling the original
implementation), we may not notice that the original implementation
rejects our method parameters.
Here this is the case: once we actually call the original implementation
the tests start to fail, because some arguments are not converted from
an ActiveRecord::Relation to a serializable array.
This is fixed by ensuring that the mailer code is executed (and doesn't
throw an exception).
2020-05-18 16:24:08 +02:00
krichtof
1b07631336
Merge pull request #5133 from betagouv/5130-indiquer-pieces-recuperees
...
informe l'usager des attestations récupérées
2020-05-18 16:10:40 +02:00
Christophe Robillard
d4bb5d1f56
indique à l'usager les pièces ajoutées au dossier
...
- attestation sociale
- attestation fiscale
- bilans bdf
2020-05-18 16:01:13 +02:00
Keirua
6cf2ca7cfb
Merge pull request #5143 from betagouv/remove-birthday-column
...
Export tableur : suppression de la colonne "Date de naissance"
2020-05-18 15:27:52 +02:00
Pierre de La Morinerie
b63fa0e6b8
dossier: remove "Birthdate" column from export
2020-05-18 13:14:28 +00:00
Pierre de La Morinerie
00adb006b4
specs: improve ProcedureExportService spec
2020-05-18 13:14:28 +00:00
Keirua
99ece20cb2
Merge pull request #5145 from betagouv/5140-anonymisation-instructeurs
...
#5140 - Anonymisation de l'instructeur dans la messagerie
2020-05-18 15:13:47 +02:00
clemkeirua
77101208a4
Anonymisation de l'instructeur dans la messagerie
2020-05-18 12:56:30 +00:00
Keirua
23316b6e4e
Merge pull request #5167 from betagouv/export-brouillons
...
Ajout d'un bouton d'export des mails des demandeurs
2020-05-18 14:55:47 +02:00
clemkeirua
8542fd9f47
unique emails + remove n+1
2020-05-18 12:46:42 +00:00
clemkeirua
22a518c921
ajout d'un bouton d'export des mails des demandeurs
2020-05-18 12:46:42 +00:00
Pierre de La Morinerie
c576b457ff
Merge pull request #5166 from betagouv/better-alt-procedure
...
Usager : le service administratif de la démarche est maintenant accessible aux lecteurs d'écrans
2020-05-18 14:33:16 +02:00
clemkeirua
9454017dd9
afficher le nom du service en alt si possible
2020-05-18 14:17:21 +02:00
Keirua
a5be836a55
Merge pull request #5160 from betagouv/rollback-all-the-things
...
Tasks : ajout d'une tâche pour déclencher un rollback
2020-05-18 13:32:57 +02:00
Pierre de La Morinerie
77ab7d1462
tasks: add a rollback task
2020-05-18 12:59:12 +02:00
Pierre de La Morinerie
0738c6ff18
Merge pull request #5159 from betagouv/file-upload-really-mute-errors
2020-05-18 11:57:37 +02:00