Commit graph

68 commits

Author SHA1 Message Date
gregoirenovel
26b66aac96 Improve a method name 2018-04-09 09:54:11 +02:00
gregoirenovel
71e9a6056d Structure the helpers methods the same way 2018-04-09 09:54:10 +02:00
gregoirenovel
c5953f8aef Use .join to generate urls (unification) 2018-04-09 09:54:10 +02:00
gregoirenovel
298d7d050c Mutualize some code in Pipedrive::API#put 2018-04-09 09:54:10 +02:00
gregoirenovel
e688fc4212 Mutualize some code in Pipedrive::API#get 2018-04-09 09:54:10 +02:00
gregoirenovel
d202e0173e Mutualize some code in Pipedrive::API#get 2018-04-09 09:54:10 +02:00
gregoirenovel
d287eb0e5f Create Pipedrive::API get helpers 2018-04-09 09:54:10 +02:00
gregoirenovel
4ff07f2b93 Mutualize a call Pipedrive::API.put 2018-04-09 09:54:10 +02:00
gregoirenovel
e31b839e0c Create Pipedrive::API put helpers 2018-04-09 09:54:10 +02:00
gregoirenovel
e71d3a76fa Refactor Pipedrive: create adapters and an API files 2018-04-09 09:54:10 +02:00
gregoirenovel
094ccecc01 Rename Adapter’s siret_or_siren to siret 2018-03-29 16:06:14 +02:00
gregoirenovel
8938a5b40d Delete SiretService.siren, move its code to EntrepriseAdapter#get_resource 2018-03-29 16:06:14 +02:00
gregoirenovel
cc9e318210 Add a comment to explain why we reject 206 responses 2018-03-29 15:36:41 +02:00
gregoirenovel
67cf614879 Mutualize some code on ApiEntreprise::Adapter 2018-03-29 11:44:59 +02:00
gregoirenovel
5f1394cd7f ExercicesAdapter#to_array -> ExercicesAdapter#to_params 2018-03-29 11:44:59 +02:00
gregoirenovel
68c9849977 Mutualize the adapters’ #data_source methods 2018-03-29 11:44:59 +02:00
gregoirenovel
a9360a8be2 Mutualize Adapter initialization in a class and method 2018-03-29 11:44:59 +02:00
gregoirenovel
681e33b850 Simplify RNAAdapter#to_params and unify the type of objects it returns 2018-03-28 10:55:15 +02:00
gregoirenovel
caf2e50954 Make #to_params return blank hashes if we have no data 2018-03-28 10:55:15 +02:00
gregoirenovel
de483ac0f6 Format all attr_to_fetch methods the same way 2018-03-28 10:55:14 +02:00
gregoirenovel
3dd76c3d68 Remove useless success? methods 2018-03-28 10:55:14 +02:00
gregoirenovel
a9c1c9f551 Improve #success? methods 2018-03-28 10:55:14 +02:00
gregoirenovel
19add3f534 Use if-flows instead of rescue-flows 2018-03-28 10:55:14 +02:00
gregoirenovel
182afee970 to_params -> to_array 2018-03-28 10:52:54 +02:00
gregoirenovel
3e16eff9a0 Unify data_source methods 2018-03-28 10:50:27 +02:00
Paul Chavard
2f68b7c4b3 Tweak timeout API Entreprises 2018-03-27 17:59:51 +02:00
Paul Chavard
5ae8eb3383 Lower timeout for API Entreprise 2018-03-27 17:16:56 +02:00
Paul Chavard
2505419b08 Treat partial success from api entreprises as errors
We might refine this later, but for now this will give an error instead of unspecified state
2018-03-26 17:44:37 +02:00
Paul Chavard
f35aef0eb6 Use Typhoeus and set agressive timeouts 2018-03-26 16:53:42 +02:00
Frederic Merizen
2fa88a432b Add missing brackets around parameters in method definitions 2018-03-20 17:54:51 +01:00
gregoirenovel
4df2eb168d Remove mandataires_sociaux 2018-03-20 16:09:00 +01:00
gregoirenovel
5658aae96b SIADE -> ApiEntreprise 2018-03-19 11:39:46 +01:00
gregoirenovel
96f78b6213 data_source methods can be private 2018-03-19 11:39:46 +01:00
gregoirenovel
9a7e13f72f Mutualise a JSON#parse call 2018-03-19 11:39:46 +01:00
gregoirenovel
57b42e24e5 SIADEURL -> API_ENTREPRISE_URL 2018-03-19 11:39:46 +01:00
gregoirenovel
658bd95f86 Add a constant to SIADEURL 2018-03-19 11:39:46 +01:00
gregoirenovel
a0a56d6f67 Add a variable for legibility 2018-03-19 11:39:46 +01:00
gregoirenovel
5628eba0a4 mandatory_params -> params 2018-03-19 11:39:46 +01:00
gregoirenovel
b71b8ea8e0 Refactor the url method 2018-03-19 11:39:46 +01:00
gregoirenovel
92e0e4c231 Remove the base_url method 2018-03-19 11:39:46 +01:00
gregoirenovel
51c030b945 Move the URL computation to a private method 2018-03-19 11:39:46 +01:00
gregoirenovel
94176f0b53 Pass a resource instead of a url to #call 2018-03-19 11:39:46 +01:00
gregoirenovel
330f99de8a Mutualise part of the URL 2018-03-19 11:39:46 +01:00
gregoirenovel
2c18541256 Mutualise base_url call 2018-03-19 11:39:46 +01:00
gregoirenovel
6902f502d3 Mutualise mandatory_params call 2018-03-19 11:39:46 +01:00
gregoirenovel
9daf0ee608 Remove useless attribute default 2018-03-19 11:39:46 +01:00
Mathieu Magnin
ab368d44a1 [Fix #1500] Add mandatory params to call api entreprise v2 2018-03-15 14:51:42 +01:00
gregoirenovel
7489b8d1aa Avoid assignments in conditions 2018-03-06 17:18:44 +01:00
Paul Chavard
94a503a2c4 Fix create dossier with siret 2018-02-28 17:16:03 +01:00
Paul Chavard
896518f3d5 add SIRETService 2018-02-27 16:22:53 +01:00